-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show the correct number of threads of agg in explain analyze #5367
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
|
/run-all-tests |
/check-issue-triage-complete |
/// We consider the number of streams as the concurrency of the operator and pass it to tidb. | ||
for (size_t i = 1; i < concurrency; ++i) | ||
profile_streams.emplace_back(std::make_shared<NullBlockInputStream>(header)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we fill the concurrency to the response in here?
tiflash/dbms/src/Flash/Coprocessor/DAGResponseWriter.cpp
Lines 94 to 103 in f97567a
/// part 1: local execution info | |
for (const auto & stream_ptr : streams) | |
{ | |
if (auto * p_stream = dynamic_cast<IProfilingBlockInputStream *>(stream_ptr.get())) | |
{ | |
current.time_processed_ns = std::max(current.time_processed_ns, p_stream->getProfileInfo().execution_time); | |
current.num_produced_rows += p_stream->getProfileInfo().rows; | |
current.num_iterations += p_stream->getProfileInfo().blocks; | |
} | |
current.concurrency++; |
I don't get it that why using NullBlockInputStream
here won't affect the number of actual rows, actual process time, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because NullBlockInputStream
is not IProfilingBlockInputStream
..
Coverage for changed files
Coverage summary
full coverage report (for internal network access only) |
Co-authored-by: JaySon <[email protected]>
/hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
will fixed by #5321 |
What problem does this PR solve?
Issue Number: close #5314
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note