Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpreter: Run interpreter test without exchange executors #4788

Merged
merged 29 commits into from
May 10, 2022

Conversation

ywqzzy
Copy link
Contributor

@ywqzzy ywqzzy commented Apr 28, 2022

What problem does this PR solve?

Issue Number: ref #4609

Problem Summary:

What is changed and how it works?

Mock TableScanBlockInputStreams for interpreter tests.
Add stream size configure for user to choose the concurrency of inputstreams.
Provide TiDBTableScan-->schema function, schema->column function.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 28, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Lloyd-Pottiger
  • SeaRise

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 28, 2022
@ywqzzy ywqzzy changed the title [WIP] Interpreter: Run interpreter test Interpreter: Run interpreter test Apr 28, 2022
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 28, 2022
@ywqzzy ywqzzy requested a review from SeaRise April 28, 2022 07:07
@ywqzzy ywqzzy changed the title Interpreter: Run interpreter test Interpreter: Run interpreter test without exchange executors Apr 29, 2022
dbms/src/Flash/Coprocessor/DAGContext.h Outdated Show resolved Hide resolved
dbms/src/Flash/Coprocessor/InterpreterDAG.cpp Outdated Show resolved Hide resolved
dbms/src/Storages/Transaction/TiDB.cpp Outdated Show resolved Hide resolved
dbms/src/Storages/Transaction/TiDB.h Outdated Show resolved Hide resolved
dbms/src/TestUtils/tests/gtest_mock_executors.cpp Outdated Show resolved Hide resolved
@SeaRise SeaRise self-requested a review May 5, 2022 10:32
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 5, 2022
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 6, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 6, 2022
@SeaRise SeaRise requested a review from windtalker May 6, 2022 02:34
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 10, 2022
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ywqzzy
Copy link
Contributor Author

ywqzzy commented May 10, 2022

/merge

@ti-chi-bot
Copy link
Member

@ywqzzy: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ced4d51

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 10, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented May 10, 2022

Coverage for changed files

Filename                                             Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
DataStreams/MockTableScanBlockInputStream.cpp             13                 0   100.00%           3                 0   100.00%          32                 1    96.88%          10                 1    90.00%
DataStreams/MockTableScanBlockInputStream.h                2                 0   100.00%           2                 0   100.00%           4                 0   100.00%           0                 0         -
Flash/Coprocessor/DAGContext.h                            37                13    64.86%          28                11    60.71%          83                31    62.65%          12                 6    50.00%
Flash/Coprocessor/DAGQueryBlockInterpreter.cpp           294                94    68.03%          40                 4    90.00%         669               180    73.09%         220                96    56.36%
Flash/Coprocessor/DAGQueryBlockInterpreter.h               2                 0   100.00%           2                 0   100.00%           2                 0   100.00%           0                 0         -
Flash/Coprocessor/GenSchemaAndColumn.cpp                  10                 2    80.00%           2                 0   100.00%          32                 6    81.25%          10                 3    70.00%
Flash/Coprocessor/InterpreterDAG.cpp                      23                 4    82.61%           5                 0   100.00%          60                 8    86.67%          16                 6    62.50%
Flash/Coprocessor/TiDBTableScan.h                          6                 4    33.33%           6                 4    33.33%          18                12    33.33%           0                 0         -
Flash/tests/gtest_interpreter.cpp                         72                38    47.22%           3                 0   100.00%         214                 0   100.00%           8                 8     0.00%
TestUtils/InterpreterTestUtils.cpp                        46                 8    82.61%           6                 1    83.33%          37                 5    86.49%          12                 6    50.00%
TestUtils/InterpreterTestUtils.h                           2                 0   100.00%           2                 0   100.00%           5                 0   100.00%           0                 0         -
TestUtils/mockExecutor.cpp                                57                 9    84.21%          34                 7    79.41%         224                38    83.04%          28                 2    92.86%
TestUtils/tests/gtest_mock_executors.cpp                 238               171    28.15%          10                 0   100.00%         204                 0   100.00%          36                36     0.00%
WindowFunctions/tests/gtest_window_functions.cpp          83                22    73.49%          14                 0   100.00%         237                 0   100.00%          38                 7    81.58%
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                    885               365    58.76%         157                27    82.80%        1821               281    84.57%         390               171    56.15%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18105      9880             45.43%    201493  98626        51.05%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit f601de1 into pingcap:master May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants