Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpreter: Remove system query #4590

Merged
merged 4 commits into from
May 13, 2022
Merged

Interpreter: Remove system query #4590

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9112c3b
update.
ywqzzy Apr 6, 2022
c6f59c7
Merge branch 'master' into remove_ast_8
ywqzzy May 12, 2022
e86b65d
Merge branch 'master' into remove_ast_8
ti-chi-bot May 12, 2022
7f2ffbf
Merge branch 'master' into remove_ast_8
ti-chi-bot May 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions dbms/src/Interpreters/InterpreterFactory.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
#include <Interpreters/InterpreterSetQuery.h>
#include <Interpreters/InterpreterShowProcesslistQuery.h>
#include <Interpreters/InterpreterShowTablesQuery.h>
#include <Interpreters/InterpreterSystemQuery.h>
#include <Interpreters/InterpreterUseQuery.h>
#include <Parsers/ASTAlterQuery.h>
#include <Parsers/ASTCreateQuery.h>
Expand All @@ -42,7 +41,6 @@
#include <Parsers/ASTSetQuery.h>
#include <Parsers/ASTShowProcesslistQuery.h>
#include <Parsers/ASTShowTablesQuery.h>
#include <Parsers/ASTSystemQuery.h>
#include <Parsers/ASTUseQuery.h>
#include <Parsers/TablePropertiesQueriesASTs.h>

Expand Down Expand Up @@ -136,11 +134,7 @@ std::unique_ptr<IInterpreter> InterpreterFactory::get(ASTPtr & query, Context &
{
return std::make_unique<InterpreterDBGInvokeQuery>(query, context);
}
else if (typeid_cast<ASTSystemQuery *>(query.get()))
{
throwIfReadOnly(context);
return std::make_unique<InterpreterSystemQuery>(query, context);
}

else if (typeid_cast<ASTManageQuery *>(query.get()))
{
throwIfReadOnly(context);
Expand Down
131 changes: 0 additions & 131 deletions dbms/src/Interpreters/InterpreterSystemQuery.cpp
View file
Open in desktop

This file was deleted.

39 changes: 0 additions & 39 deletions dbms/src/Interpreters/InterpreterSystemQuery.h
View file
Open in desktop

This file was deleted.

84 changes: 0 additions & 84 deletions dbms/src/Parsers/ASTSystemQuery.cpp
View file
Open in desktop

This file was deleted.

67 changes: 0 additions & 67 deletions dbms/src/Parsers/ASTSystemQuery.h
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions dbms/src/Parsers/ParserQuery.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
#include <Parsers/ParserQueryWithOutput.h>
#include <Parsers/ParserRenameQuery.h>
#include <Parsers/ParserSetQuery.h>
#include <Parsers/ParserSystemQuery.h>
#include <Parsers/ParserUseQuery.h>

namespace DB
Expand All @@ -34,15 +33,13 @@ bool ParserQuery::parseImpl(Pos & pos, ASTPtr & node, Expected & expected)
ParserUseQuery use_p;
ParserSetQuery set_p;
ParserDBGInvokeQuery dbginvoke_p;
ParserSystemQuery system_p;
ParserManageQuery manage_p;

bool res = query_with_output_p.parse(pos, node, expected)
|| insert_p.parse(pos, node, expected)
|| use_p.parse(pos, node, expected)
|| set_p.parse(pos, node, expected)
|| dbginvoke_p.parse(pos, node, expected)
|| system_p.parse(pos, node, expected)
|| manage_p.parse(pos, node, expected);

return res;
Expand Down
Loading