FLASH-796: support rename pk column #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanfei1991
commented
Jan 7, 2020
| @@ -247,44 +259,37 @@ void SchemaBuilder<Getter>::applyDiff(const SchemaDiff & diff) | |||
| switch (diff.type) | |||
| { | |||
| case SchemaActionCreateTable: | |||
| case SchemaActionRecoverTable: | |||
| { | |||
| case SchemaActionRecoverTable: { | |||
There was a problem hiding this comment.
changed by clang-format
|
/run-integration-tests |
|
/run-integration-tests |
1 similar comment
|
/run-integration-tests |
|
/run-integration-tests |
1 similar comment
|
/run-integration-tests |
zanmato1984
reviewed
Jan 9, 2020
zanmato1984
reviewed
Jan 9, 2020
zanmato1984
reviewed
Jan 9, 2020
zanmato1984
reviewed
Jan 9, 2020
zanmato1984
reviewed
Jan 9, 2020
zanmato1984
reviewed
Jan 9, 2020
zanmato1984
changed the title
zanmato1984
reviewed
Jan 9, 2020
| if (params.size() != 1) | ||
| { | ||
| throw Exception("There is an internal error for rename columns", ErrorCodes::LOGICAL_ERROR); | ||
| throw Exception("There is an internal error for rename columns, params size should be 1", ErrorCodes::LOGICAL_ERROR); |
There was a problem hiding this comment.
When you are reporting errors like this, it's always better to say "SOME SIZE is Y, should be X" than "SOME SIZE is not X".
|
/run-integration-tests |
|
/run-integration-tests |
This was referenced Sep 4, 2024
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When changing pk column, we should change the pk_ast in
MergeTreeDataat the same time。test is added in full_stack_test, because common integration tests don't support create pk col.