Review result #376
Closed
Review result #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -105,6 +108,7 @@ class VersionSet | |||
|
|
|||
| virtual ~VersionSet() | |||
| { | |||
| // REVIEW: why this doesn't need the mutex? | |||
There was a problem hiding this comment.
All versions of this VersionSet must be released before destructuring VersionSet, so we don't need to lock on mutex.
| @@ -183,9 +188,11 @@ class VersionSet | |||
| } | |||
|
|
|||
| protected: | |||
| // REVIEW: why can't we just use std::list? | |||
There was a problem hiding this comment.
I thought we can lock on small parts of versions instead of the whole version-list, but now it seems to be the same as lock over the list...
dbms/src/Storages/Page/PageEntries.h
Outdated
| @@ -232,6 +233,7 @@ void PageEntriesMixin<T>::put(PageId page_id, const PageEntry & entry) | |||
| max_page_id = std::max(max_page_id, page_id); | |||
| } | |||
|
|
|||
| // REVIEW: the name `move` confused me for a while, until I see this code | |||
There was a problem hiding this comment.
Rename to updateNormalPage
| // REVIEW: small opinion: I think this is a bit over engineering, cause this struct doesn't need to serialize, | ||
| // even if it need to serialize, we could use pragma packing, | ||
| // or use union{char, uint32}, union can be more reliable (if we change the type of WriteType, it don't cause problem) | ||
| // manually padding seems to be the worst way to do it. |
dbms/src/Storages/Page/PageEntries.h
Outdated
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| #include <cassert> | |||
| #include <optional> | |||
| // REVIEW: mutex unused | |||
| VersionType placeholder_node; // Head of circular double-linked list of all versions | ||
| VersionPtr current; // current version; current == placeholder_node.prev | ||
|
|
||
| // REVIEW: this name is not accurate, cause this mutex also be used for editing |
| @@ -341,6 +343,7 @@ class VersionSetWithDelta | |||
| } | |||
|
|
|||
| protected: | |||
| // REVIEW: this name is not accurate, cause this mutex also be used for editing | |||
| @@ -292,6 +293,7 @@ class VersionSetWithDelta | |||
| tail.reset(); | |||
| } | |||
|
|
|||
| // REVIEW: maybe relocate this two methods to VersionType? | |||
| @@ -131,6 +131,7 @@ class VersionSetWithDelta | |||
| CurrentMetrics::add(CurrentMetrics::PSMVCCNumSnapshots); | |||
| } | |||
|
|
|||
| // REVIEW: make sure Snapshot is uncopyable, or this will go wrong | |||
| @@ -140,6 +144,7 @@ class VersionSet | |||
| return sz; | |||
| } | |||
|
|
|||
| // REVIEW: I read the tests, and I think lock it up should be better | |||
|
All addressed, close this now |
This was referenced Sep 4, 2024
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.