Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix can't found PageFile after hardlink. #3645

Merged
merged 9 commits into from
Dec 22, 2021
Merged

Fix can't found PageFile after hardlink. #3645

merged 9 commits into from
Dec 22, 2021

Conversation

jiaqizho
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #3438

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 14, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 14, 2021
@jiaqizho jiaqizho changed the title [DNM]Enable gc_force_hardlink Fix can't found PageFile after hardlink. Dec 20, 2021
@jiaqizho
Copy link
Contributor Author

/rebuild

@jiaqizho
Copy link
Contributor Author

@JaySon-Huang PTAL

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 22, 2021
@jiaqizho
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@jiaqizho: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7f1f954

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 22, 2021
@sre-bot
Copy link
Collaborator

sre-bot commented Dec 22, 2021

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/540/cobertura/
(Coverage detail url is limited office network access)

lines: 42.5% (47585 out of 111889)
branches: 6.0% (73137 out of 1209047)

@jiaqizho
Copy link
Contributor Author

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Dec 22, 2021

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/545/cobertura/
(Coverage detail url is limited office network access)

lines: 42.5% (47587 out of 111889)
branches: 6.0% (73139 out of 1209047)

@ti-chi-bot
Copy link
Member

@jiaqizho: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented Dec 22, 2021

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/553/cobertura/
(Coverage detail url is limited office network access)

lines: 42.6% (47677 out of 111890)
branches: 6.1% (73249 out of 1209051)

@ti-chi-bot ti-chi-bot merged commit d5775e6 into pingcap:master Dec 22, 2021
@JaySon-Huang JaySon-Huang deleted the fix-fd300 branch December 23, 2021 03:33
@JaySon-Huang JaySon-Huang added the needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 label Dec 23, 2021
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Dec 23, 2021
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3722.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not find PageFile after data migrated by hard link
4 participants