Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add avg overflow test #3536

Merged
merged 3 commits into from
Dec 3, 2021
Merged

Add avg overflow test #3536

merged 3 commits into from
Dec 3, 2021

Conversation

fzhedu
Copy link
Contributor

@fzhedu fzhedu commented Nov 23, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close pingcap/tidb#29952

Problem Summary: add some tests for pingcap/tidb#30010

What is changed and how it works?

Proposal: xxx

What's Changed:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 23, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Nov 23, 2021
@fzhedu fzhedu requested a review from windtalker November 23, 2021 07:12
windtalker
windtalker approved these changes Nov 23, 2021
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 23, 2021
@fzhedu
Copy link
Contributor Author

fzhedu commented Dec 3, 2021

/merge

@ti-chi-bot
Copy link
Member

@fzhedu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 870af81

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 3, 2021
@fzhedu
Copy link
Contributor Author

fzhedu commented Dec 3, 2021

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Dec 3, 2021

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/252/cobertura/
(Coverage detail url is limited office network access)

lines: 40.2% (44306 out of 110111)
branches: 5.6% (67019 out of 1197890)

@ti-chi-bot ti-chi-bot merged commit 0422411 into pingcap:master Dec 3, 2021
@JaySon-Huang JaySon-Huang deleted the addAvgOverflowTest branch December 3, 2021 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windtalker windtalker windtalker approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TiDB + TiFlash throw out of range error for agg function avg
4 participants
@fzhedu @ti-chi-bot @sre-bot @windtalker