fix "Output offset index is out of bound" error for some update statements #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
windtalker
commented
Dec 3, 2019
windtalker
commented
- fix "Output offset index is out of bound" error for some update statements
- check the region read status in executeTS
- not sure if this pr will fix the issue in FLASH-741 or not
zanmato1984
reviewed
Dec 3, 2019
zanmato1984
reviewed
Dec 4, 2019
| @@ -145,7 +145,7 @@ BlockInputStreamPtr dbgFuncMockDAG(Context & context, const ASTs & args) | |||
| return outputDAGResponse(context, schema, dag_response); | |||
| } | |||
|
|
|||
| const String VOID_COL_NAME = "_void"; | |||
| const String ROWID_COL_NAME = "_tidb_rowid"; | |||
There was a problem hiding this comment.
No need to define this literal by ourself, there is already one defined in mutalbe_support class.
|
/rebuild |
3 similar comments
|
/rebuild |
|
/rebuild |
|
/rebuild |
|
/run-integration-tests |
This was referenced Jul 5, 2023
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.