Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FLASH-612: Remove costly logging in dag #308

Merged
merged 5 commits into from
Nov 2, 2019
Merged

FLASH-612: Remove costly logging in dag #308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bfd074d
replace function `gethostbyname` with poco api
hanfei1991 Oct 31, 2019
d585c15
Merge branch 'hanfei/fix-compile' into remove-log-in-dag
zanmato1984 Oct 31, 2019
262502f
Remove costly logging in dag expr analyzer
zanmato1984 Oct 31, 2019
8daba08
Merge branch 'master' of github.com:pingcap/tics into remove-log-in-dag
zanmato1984 Nov 1, 2019
b461cd8
Merge branch 'master' into remove-log-in-dag
zanmato1984 Nov 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions dbms/src/Flash/Coprocessor/DAGExpressionAnalyzer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,7 @@ static String genFuncString(const String & func_name, const Names & argument_nam
}

DAGExpressionAnalyzer::DAGExpressionAnalyzer(std::vector<NameAndTypePair> && source_columns_, const Context & context_)
: source_columns(std::move(source_columns_)),
context(context_),
after_agg(false),
implicit_cast_count(0),
log(&Logger::get("DAGExpressionAnalyzer"))
: source_columns(std::move(source_columns_)), context(context_), after_agg(false), implicit_cast_count(0)
{
settings = context.getSettings();
}
Expand Down Expand Up @@ -391,8 +387,6 @@ String DAGExpressionAnalyzer::appendCastIfNeeded(const tipb::Expr & expr, Expres
// todo ignore nullable info??
if (expected_type->getName() != actual_type->getName())
{
LOG_DEBUG(
log, __PRETTY_FUNCTION__ << " Add implicit cast: from " << actual_type->getName() << " to " << expected_type->getName());
implicit_cast_count++;
// need to add cast function
// first construct the second argument
Expand Down
1 change: 0 additions & 1 deletion dbms/src/Flash/Coprocessor/DAGExpressionAnalyzer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ class DAGExpressionAnalyzer : private boost::noncopyable
const Context & context;
bool after_agg;
Int32 implicit_cast_count;
Poco::Logger * log;

public:
DAGExpressionAnalyzer(std::vector<NameAndTypePair> && source_columns_, const Context & context_);
Expand Down