Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grafana panels for write throughput per instance (#2524) #2544

Merged
merged 4 commits into from
Sep 15, 2021

Conversation

ti-srebot
Copy link
Collaborator

@ti-srebot ti-srebot commented Aug 3, 2021

cherry-pick #2524 to release-5.1
You can switch your code base to this Pull Request by using git-extras:

# In tics repo:
git pr https://github.com/pingcap/tics/pull/2544

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tics.git pr/2544:release-5.1-ae1fc3ba0c97

Signed-off-by: JaySon-Huang [email protected]

What problem does this PR solve?

Issue Number: related to tikv/pd#3261

Problem Summary:

What is changed and how it works?

Add two Grafana panels that show write throughput per instance. So that we can check the write hotspot scheduling of PD

image

Related changes

  • Need to cherry-pick to the release branch: 5.0 / 5.1

Check List

Tests

  • No code

Side effects

Release note

  • Add Grafana panels for write throughput per instance

@ti-srebot ti-srebot added CHERRY-PICK cherry pick status/LGT1 Indicates that a PR has LGTM 1. type/enhancement The issue or PR belongs to an enhancement. labels Aug 3, 2021
@ti-srebot ti-srebot added this to the v5.1.1 milestone Aug 3, 2021
@JaySon-Huang JaySon-Huang modified the milestones: v5.1.1, v5.1.2 Aug 3, 2021
@JaySon-Huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 624118e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 14, 2021
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 14, 2021
@JaySon-Huang
Copy link
Contributor

/run-all-tests

@JaySon-Huang JaySon-Huang added the cherry-pick-approved Cherry pick PR approved by release team. label Sep 14, 2021
@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved and removed cherry-pick-approved Cherry pick PR approved by release team. labels Sep 14, 2021
@JaySon-Huang JaySon-Huang added the cherry-pick-approved Cherry pick PR approved by release team. label Sep 14, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Sep 15, 2021
@JaySon-Huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 8c9720a into pingcap:release-5.1 Sep 15, 2021
@JaySon-Huang JaySon-Huang deleted the release-5.1-ae1fc3ba0c97 branch September 15, 2021 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CHERRY-PICK cherry pick cherry-pick-approved Cherry pick PR approved by release team. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants