-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More debug info for DeltaTree (query_id, snapshot lifetime) #2431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JaySon-Huang <[email protected]>
Signed-off-by: JaySon-Huang <[email protected]>
Signed-off-by: JaySon-Huang <[email protected]>
Signed-off-by: JaySon-Huang <[email protected]>
/run-all-tests |
lidezhu
approved these changes
Jul 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
ti-srebot
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Jul 21, 2021
Your auto merge job has been accepted, waiting for:
|
/run-all-tests |
This was referenced Jul 22, 2021
JaySon-Huang
added a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Aug 4, 2021
JaySon-Huang
added a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Aug 4, 2021
cherry-pick to release-5.1 in #2564 |
This comment has been minimized.
This comment has been minimized.
JaySon-Huang
added a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Aug 4, 2021
cherry-pick to release-5.0 in #2568 |
flowbehappy
pushed a commit
that referenced
this pull request
Aug 4, 2021
* Ignore sequence hole among PageFile meta (#2312) * Fix bug for GC may skip unexpected WriteBatches (#2356) * Add length check while running PageStorage GC (#2394) * PageStorage skip non continuous sequence safely (#2435) * Fix PageStorage GC with high valid rate PageFile (#2436) * More debug info for DeltaTree (query_id, snapshot lifetime) (#2431) * Fix deadlock on `removeExpiredSnapshots` (#2461) * Add grafana panels for write throughput per instance (#2524)
ti-chi-bot
pushed a commit
that referenced
this pull request
Sep 1, 2021
windtalker
added a commit
that referenced
this pull request
Sep 6, 2021
Co-authored-by: JaySon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT1
Indicates that a PR has LGTM 1.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: related to #2199, #2322
Problem Summary:
After #2229, we can get the max snapshot lifetime by running SQL on TiDB[1]. But it is inconvenient for checking.
[1]
What is changed and how it works?
DMVersionFilterBlockInputStream
deconstructor so that we can track a query by logging more clearFailPoints::pause_after_copr_streams_acquired
to mock that snapshot are not released by the copr levelAsynchronousMetrics::update
run, it will collect the max oldest (stable/delta/meta) snapshot lifetime for each TiFlash instance and report it to Prometheus. Show them in the MVCC snapshots panel.Related changes
pingcap/docs
/pingcap/docs-cn
:Check List
Tests
Side effects
Release note