Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add row & bytes threshold config for CompactLog (#1997) #2004

Merged
merged 2 commits into from
May 27, 2021

Conversation

ti-srebot
Copy link
Collaborator

@ti-srebot ti-srebot commented May 26, 2021

cherry-pick #1997 to release-4.0
You can switch your code base to this Pull Request by using git-extras:

# In tics repo:
git pr https://github.com/pingcap/tics/pull/2004

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tics.git pr/2004:release-4.0-558787749f42

Signed-off-by: Zhigao Tong [email protected]

What problem does this PR solve?

Issue Number: close #1885

Problem Summary:

What is changed and how it works?

What's Changed:

  • add config about rows & bytes threshold for compact log.
  • if mem cache about one region reach any threshold( rows: 40k | bytes: 32MB | period: 120), its cache should be flushed and persisted.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

  • No release note

@ti-srebot ti-srebot added CHERRY-PICK cherry pick status/LGT1 Indicates that a PR has LGTM 1. labels May 26, 2021
@ti-srebot ti-srebot requested a review from JaySon-Huang May 26, 2021 17:12
@ti-srebot ti-srebot added this to the v4.0.13 milestone May 26, 2021
set default config about compact-log: rows 40k
@solotzg
Copy link
Contributor

solotzg commented May 27, 2021

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label May 27, 2021
@ti-srebot
Copy link
Collaborator Author

/run-all-tests

@ti-srebot ti-srebot merged commit 2e695e5 into pingcap:release-4.0 May 27, 2021
@solotzg solotzg deleted the release-4.0-558787749f42 branch May 27, 2021 03:04
@JaySon-Huang JaySon-Huang modified the milestones: v4.0.13, v4.0.14 May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CHERRY-PICK cherry pick status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants