Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interaction between EstablishCallData and MPPTunnel should be more clear #5710

Closed
gengliqi opened this issue Aug 26, 2022 · 0 comments · Fixed by #5711
Closed

Interaction between EstablishCallData and MPPTunnel should be more clear #5710

gengliqi opened this issue Aug 26, 2022 · 0 comments · Fixed by #5711
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@gengliqi
Copy link
Contributor

Enhancement

In the current codebase, the interaction between EstablishCallData and MPPTunnel is complex and error-prone.
As we can see, these two structures can call the function of each other and also hold the pointer of each other.

Several bugs related to EstablishCallData and MPPTunnel are recently fixed. For example, #5553 and #5650.

We should make the logic clear in order to easily maintain it and maybe improve it in the future.
@gengliqi gengliqi added the type/enhancement The issue or PR belongs to an enhancement. label Aug 26, 2022
@gengliqi gengliqi mentioned this issue Aug 26, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Sep 8, 2022
@gengliqi
Decouple EstablishCallData and MPPTunnel (#5711)
57cec94 
close #5710
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Decouple EstablishCallData and MPPTunnel gengliqi/tiflash
1 participant
@gengliqi