Apply suggestions from code review

Co-authored-by: JaySon <[email protected]>
pingcap · Aug 6, 2024 · b17a62a · b17a62a
1 parent 10cccd8
commit b17a62a
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/dbms/src/Flash/Coprocessor/DAGQueryInfo.h b/dbms/src/Flash/Coprocessor/DAGQueryInfo.h
@@ -47,6 +47,7 @@ struct DAGQueryInfo
     const ColumnInfos & source_columns;
     // filters in dag request
     const google::protobuf::RepeatedPtrField<tipb::Expr> & filters;
+    // filters for approximate nearest neighbor (ann) vector search
     const tipb::ANNQueryInfo & ann_query_info;
     // filters have been push down to storage engine in dag request
     const google::protobuf::RepeatedPtrField<tipb::Expr> & pushed_down_filters;

diff --git a/dbms/src/TiDB/Schema/TiDB.cpp b/dbms/src/TiDB/Schema/TiDB.cpp
@@ -479,7 +479,7 @@ try
 
         vector_index->dimension = vector_index_json->getValue<UInt64>("dimension");
         RUNTIME_CHECK(vector_index->dimension > 0);
-        RUNTIME_CHECK(vector_index->dimension <= 16000); // Just a protection
+        RUNTIME_CHECK(vector_index->dimension <= 16383); // Just a protection
 
         auto distance_metric
             = magic_enum::enum_cast<DistanceMetric>(vector_index_json->getValue<String>("distance_metric"));

diff --git a/dbms/src/TiDB/Schema/TiDB.h b/dbms/src/TiDB/Schema/TiDB.h
@@ -204,6 +204,7 @@ struct ColumnInfo
     SchemaState state = StateNone;
     String comment;
 
+    // TODO: This index will be moved to the table level later
     VectorIndexInfoPtr vector_index = nullptr;
 
 #ifdef M