privilege: alter table && rename privilege make same with MySQL #9872

xiekeyi98 · 2019-03-24T07:44:15Z

What problem does this PR solve?

In MySQL:https://dev.mysql.com/doc/refman/5.7/en/privileges-provided.html#priv_alter

Enables use of the ALTER TABLE statement to change the structure of tables. ALTER TABLE also requires the CREATE and INSERT privileges. Renaming a table requires ALTER and DROP on the old table, CREATE, and INSERT on the new table.

Enables use of statements that drop (remove) existing databases, tables, and views. The DROP privilege is required to use the ALTER TABLE ... DROP PARTITION statement on a partitioned table. The DROP privilege is also required for TRUNCATE TABLE.

What is changed and how it works?

Add more privileges in alter table and rename to make the same with MySQL.

Check List

Tests

Unit test
Integration test

This change is

Enables use of the ALTER TABLE statement to change the structure of tables. ALTER TABLE also requires the CREATE and INSERT privileges.

same with MySQL.

Renaming a table requires ALTER and DROP on the old table, CREATE, and INSERT on the new table.

planner/core/planbuilder.go

xiekeyi98 · 2019-03-24T07:48:38Z

truncate table isn't also the same with MySQL.
It will be fixed in #9870

codecov · 2019-03-24T07:53:00Z

Codecov Report

Merging #9872 into master will decrease coverage by 0.001%.
The diff coverage is 100%.

@@               Coverage Diff                @@
##             master      #9872        +/-   ##
================================================
- Coverage   67.3512%   67.3501%   -0.0011%     
================================================
  Files           383        383                
  Lines         80444      80466        +22     
================================================
+ Hits          54180      54194        +14     
- Misses        21421      21422         +1     
- Partials       4843       4850         +7

codecov · 2019-03-24T07:53:00Z

Codecov Report

Merging #9872 into master will decrease coverage by 0.0166%.
The diff coverage is 68.932%.

@@               Coverage Diff                @@
##             master      #9872        +/-   ##
================================================
- Coverage   77.7215%   77.7049%   -0.0167%     
================================================
  Files           403        403                
  Lines         81873      81942        +69     
================================================
+ Hits          63633      63673        +40     
- Misses        13547      13572        +25     
- Partials       4693       4697         +4

planner/core/planbuilder.go

crazycs520

Mostly LGTM

planner/core/planbuilder.go

winkyao · 2019-03-26T03:22:29Z

planner/core/logical_plan_test.go

@@ -1640,6 +1640,39 @@ func (s *testPlanSuite) TestVisitInfo(c *C) {
 				{mysql.AllPrivMask, "test", "ttt", "", nil},
 			},
 		},
+		{
+			sql: "alter table t add column a int(4)",


Please remember to update our document.

pingcap/docs-cn#1192

crazycs520

LGTM

planner/core/planbuilder.go

winkyao

LGTM

planner/core/planbuilder.go

xiekeyi98 · 2019-04-03T03:13:38Z

@zz-jason PTAL.
Any else should I change?

xiekeyi98 · 2019-04-03T05:26:18Z

/run-all-tests

zz-jason

LGTM

xiekeyi98 · 2019-04-04T05:22:47Z

/run-all-tests

xiekeyi98 · 2019-04-04T05:54:42Z

/run-all-tests

xiekeyi98 · 2019-04-04T06:25:41Z

/run-all-tests

xiekeyi98 · 2019-04-04T06:53:02Z

/run-common-tests tidb-test=pr/776

xiekeyi98 · 2019-04-04T07:14:24Z

/run-all-tests

xiekeyi98 added 4 commits March 24, 2019 14:51

ALTER TABLE PRIV

58e7cf5

Enables use of the ALTER TABLE statement to change the structure of tables. ALTER TABLE also requires the CREATE and INSERT privileges.

Create database priv

ab01070

same with MySQL.

Rename priv

4028a79

Renaming a table requires ALTER and DROP on the old table, CREATE, and INSERT on the new table.

buildDDL Finsh

22da92c

xiekeyi98 commented Mar 24, 2019

View reviewed changes

planner/core/planbuilder.go Outdated Show resolved Hide resolved

xiekeyi98 added type/compatibility component/privilege labels Mar 24, 2019

xiekeyi98 added 2 commits March 24, 2019 18:51

alter table rename ( ugly )

458fc0a

Merge remote-tracking branch 'upstream/master' into TiDB-3397

d68640a

crazycs520 reviewed Mar 24, 2019

View reviewed changes

planner/core/planbuilder.go Outdated Show resolved Hide resolved

crazycs520 reviewed Mar 24, 2019

View reviewed changes

xiekeyi98 added the status/WIP label Mar 25, 2019

xiekeyi98 added 3 commits March 25, 2019 10:30

apply comment

30554f5

alter table drop partition

4003b21

Merge remote-tracking branch 'upstream/master' into TiDB-3397

51baf39

xiekeyi98 marked this pull request as ready for review March 25, 2019 04:23

xiekeyi98 removed the status/WIP label Mar 25, 2019

xiekeyi98 commented Mar 25, 2019

View reviewed changes

planner/core/planbuilder.go Outdated Show resolved Hide resolved

xiekeyi98 mentioned this pull request Mar 25, 2019

EXPLAIN Select * from view requires different privileges to MySQL #9875

Closed

winkyao reviewed Mar 26, 2019

View reviewed changes

xiekeyi98 added 2 commits March 27, 2019 10:57

Merge remote-tracking branch 'upstream/master' into TiDB-3397

89c099b

use iter

0f8049e

xiekeyi98 mentioned this pull request Mar 27, 2019

sql: add more privileges info pingcap/docs-cn#1192

Merged

crazycs520 reviewed Mar 29, 2019

View reviewed changes

zz-jason reviewed Mar 30, 2019

View reviewed changes

planner/core/planbuilder.go Outdated Show resolved Hide resolved

winkyao previously approved these changes Mar 31, 2019

View reviewed changes

Merge branch 'master' into TiDB-3397

82ee3d1

add error

32fd19f

xiekeyi98 commented Mar 31, 2019

View reviewed changes

planner/core/planbuilder.go Outdated Show resolved Hide resolved

fix CI

2595458

xiekeyi98 commented Mar 31, 2019

View reviewed changes

planner/core/planbuilder.go Outdated Show resolved Hide resolved

xiekeyi98 added the status/WIP label Apr 1, 2019

xiekeyi98 added 2 commits April 1, 2019 10:52

add Err DBaccessDenied

9f251e6

Merge remote-tracking branch 'upstream/master' into TiDB-3397

e3a2fdf

xiekeyi98 removed the status/WIP label Apr 1, 2019

xiekeyi98 requested a review from zz-jason April 1, 2019 03:23

xiekeyi98 added the status/WIP label Apr 1, 2019

xiekeyi98 added 2 commits April 1, 2019 13:34

delete CREATE INSERT when ALTER

7ced1f0

Merge remote-tracking branch 'upstream/master' into TiDB-3397

33b4acb

xiekeyi98 removed the status/WIP label Apr 1, 2019

Merge branch 'master' into TiDB-3397

44142ea

zz-jason approved these changes Apr 4, 2019

View reviewed changes

zz-jason added the status/LGT2 Indicates that a PR has LGTM 2. label Apr 4, 2019

Merge branch 'master' into TiDB-3397

3ba732d

Merge branch 'master' into TiDB-3397

bd45535

xiekeyi98 added 2 commits April 4, 2019 15:00

Merge branch 'master' into TiDB-3397

425ac14

Merge branch 'master' into TiDB-3397

295e3ad

xiekeyi98 merged commit 054517e into pingcap:master Apr 4, 2019

xiekeyi98 deleted the TiDB-3397 branch April 4, 2019 07:35

sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

privilege: alter table && rename privilege make same with MySQL #9872

privilege: alter table && rename privilege make same with MySQL #9872

xiekeyi98 commented Mar 24, 2019 •

edited

Loading

xiekeyi98 commented Mar 24, 2019

codecov bot commented Mar 24, 2019

codecov bot commented Mar 24, 2019 •

edited

Loading

crazycs520 left a comment

winkyao Mar 26, 2019

xiekeyi98 Mar 27, 2019 •

edited

Loading

crazycs520 left a comment

winkyao left a comment

xiekeyi98 commented Apr 3, 2019

xiekeyi98 commented Apr 3, 2019

zz-jason left a comment

xiekeyi98 commented Apr 4, 2019

xiekeyi98 commented Apr 4, 2019

xiekeyi98 commented Apr 4, 2019

xiekeyi98 commented Apr 4, 2019

xiekeyi98 commented Apr 4, 2019

privilege: alter table && rename privilege make same with MySQL #9872

privilege: alter table && rename privilege make same with MySQL #9872

Conversation

xiekeyi98 commented Mar 24, 2019 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

xiekeyi98 commented Mar 24, 2019

codecov bot commented Mar 24, 2019

Codecov Report

codecov bot commented Mar 24, 2019 • edited Loading

Codecov Report

crazycs520 left a comment

Choose a reason for hiding this comment

winkyao Mar 26, 2019

Choose a reason for hiding this comment

xiekeyi98 Mar 27, 2019 • edited Loading

Choose a reason for hiding this comment

crazycs520 left a comment

Choose a reason for hiding this comment

winkyao left a comment

Choose a reason for hiding this comment

xiekeyi98 commented Apr 3, 2019

xiekeyi98 commented Apr 3, 2019

zz-jason left a comment

Choose a reason for hiding this comment

xiekeyi98 commented Apr 4, 2019

xiekeyi98 commented Apr 4, 2019

xiekeyi98 commented Apr 4, 2019

xiekeyi98 commented Apr 4, 2019

xiekeyi98 commented Apr 4, 2019

xiekeyi98 commented Mar 24, 2019 •

edited

Loading

codecov bot commented Mar 24, 2019 •

edited

Loading

xiekeyi98 Mar 27, 2019 •

edited

Loading