Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sessionctx: add time zone check #9822

Merged
merged 8 commits into from
Mar 30, 2019
Merged

sessionctx: add time zone check #9822

merged 8 commits into from
Mar 30, 2019

Conversation

WangXiangUSTC
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC commented Mar 20, 2019 •
edited by zz-jason
Loading

What problem does this PR solve?

fix #9775

What is changed and how it works?

add a check, hour should not greater than 12, and add unit test case

Check List

Tests

  • Unit test

Code changes

@codecov
Copy link

codecov bot commented Mar 20, 2019 •
edited
Loading

Codecov Report

Merging #9822 into master will decrease coverage by 0.0007%.
The diff coverage is 100%.

@@               Coverage Diff                @@
##             master      #9822        +/-   ##
================================================
- Coverage   77.5273%   77.5265%   -0.0008%     
================================================
  Files           404        404                
  Lines         81726      81732         +6     
================================================
+ Hits          63360      63364         +4     
  Misses        13660      13660                
- Partials       4706       4708         +2

@WangXiangUSTC
Copy link
Contributor Author

/run-all-tests

@XuHuaiyu XuHuaiyu changed the title add time zone check sessionctx: add time zone check Mar 20, 2019
@morgo morgo self-requested a review March 22, 2019 15:27
@qw4990 qw4990 mentioned this pull request Mar 23, 2019
Closed
30 tasks
morgo
morgo reviewed Mar 27, 2019
View reviewed changes
Copy link
Contributor

@morgo morgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morgo morgo added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 27, 2019
zz-jason
zz-jason approved these changes Mar 30, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason
Copy link
Member

/run-all-tests

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 30, 2019
@zz-jason zz-jason merged commit ffc97a7 into pingcap:master Mar 30, 2019
@zz-jason
Copy link
Member

@WangXiangUSTC please cherry pick this PR to release 2.1

@WangXiangUSTC WangXiangUSTC deleted the xiang/time_zone branch April 1, 2019 03:02
WangXiangUSTC added a commit to WangXiangUSTC/tidb that referenced this pull request Apr 2, 2019
@WangXiangUSTC
sessionctx: add time zone check (pingcap#9822)
3fc4755
@WangXiangUSTC WangXiangUSTC mentioned this pull request Apr 2, 2019
Merged
zz-jason pushed a commit that referenced this pull request Apr 2, 2019
@WangXiangUSTC @zz-jason
sessionctx: add time zone check (#9822) (#10000)
ebc9904
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erjiaqing erjiaqing erjiaqing left review comments

@morgo morgo morgo left review comments

@zz-jason zz-jason zz-jason approved these changes

Assignees
No one assigned
Labels
status/LGT2 Indicates that a PR has LGTM 2. type/compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

set time_zone is not compatible with MySQL
4 participants
@WangXiangUSTC @zz-jason @morgo @erjiaqing