Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

binlog: update binlog enable config && add tidb_log_bin system variable #9625

Merged
merged 12 commits into from
Mar 11, 2019
Merged

binlog: update binlog enable config && add tidb_log_bin system variable #9625

merged 12 commits into from
Mar 11, 2019

Conversation

WangXiangUSTC
Copy link
Contributor

What problem does this PR solve?

will enable binlog by system variable tidb_log_bin when binlog.enable = "auto"

What is changed and how it works?

  1. change binlog.enable's type to string, value can be "auto", "on" or "off".
  2. add global system variable tidb_log_bin

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported variable/fields change

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update the tidb-ansible repository
  • Need to be included in the release note

@codecov
Copy link

codecov bot commented Mar 9, 2019 •
edited
Loading

Codecov Report

Merging #9625 into master will decrease coverage by 0.0139%.
The diff coverage is 33.3333%.

@@              Coverage Diff               @@
##            master      #9625       +/-   ##
==============================================
- Coverage   67.436%   67.4221%   -0.014%     
==============================================
  Files          376        376               
  Lines        79195      79201        +6     
==============================================
- Hits         53406      53399        -7     
- Misses       21022      21030        +8     
- Partials      4767       4772        +5

@WangXiangUSTC WangXiangUSTC requested a review from jackysp March 11, 2019 02:19
@jackysp jackysp requested a review from imtbkcat March 11, 2019 03:23
@imtbkcat
Copy link

/run-all-tests

@WangXiangUSTC
Copy link
Contributor Author

/run-all-tests

1 similar comment
@imtbkcat
Copy link

/run-all-tests

@WangXiangUSTC
Copy link
Contributor Author

/run-integration-ddl-test

@zhouqiang-cl
Copy link
Contributor

/run-all-tests

imtbkcat
imtbkcat reviewed Mar 11, 2019
View reviewed changes
Copy link

@imtbkcat imtbkcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imtbkcat imtbkcat added status/LGT1 Indicates that a PR has LGTM 1. status/all tests passed labels Mar 11, 2019
jackysp
jackysp previously approved these changes Mar 11, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 11, 2019
zz-jason
zz-jason approved these changes Mar 11, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason merged commit 0dada1e into pingcap:master Mar 11, 2019
@gregwebs gregwebs mentioned this pull request Mar 12, 2019
Closed
@WangXiangUSTC WangXiangUSTC deleted the xiang/binlog_config branch March 13, 2019 02:20
@WangXiangUSTC WangXiangUSTC mentioned this pull request Mar 13, 2019
Merged
WangXiangUSTC added a commit to WangXiangUSTC/tidb that referenced this pull request Mar 22, 2019
@WangXiangUSTC
Revert "binlog: update binlog enable config && add tidb_log_bin syste…
dd30679 
…m variable (pingcap#9625)"

This reverts commit 0dada1e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imtbkcat imtbkcat imtbkcat left review comments

@zz-jason zz-jason zz-jason approved these changes

@jackysp jackysp jackysp left review comments

Assignees
No one assigned
Labels
component/binlog status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@WangXiangUSTC @imtbkcat @zhouqiang-cl @jackysp @zz-jason