planner/core: fix unexpected error of window function #9567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eurekaka
reviewed
Mar 6, 2019
go.mod
Outdated
| @@ -87,3 +87,5 @@ require ( | |||
| sourcegraph.com/sourcegraph/appdash v0.0.0-20180531100431-4c381bd170b4 | |||
| sourcegraph.com/sourcegraph/appdash-data v0.0.0-20151005221446-73f23eafcf67 | |||
| ) | |||
|
|
|||
| replace gihtub.com/pingcap/parser => github.com/winoros/parser v0.0.0-20190305081723-e7cb6045c53f | |||
There was a problem hiding this comment.
Yes, this fix needs changes from parser.
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #9567 +/- ##
==============================================
+ Coverage 67.41% 67.4322% +0.0222%
==============================================
Files 376 376
Lines 79190 79195 +5
==============================================
+ Hits 53382 53403 +21
+ Misses 21036 21021 -15
+ Partials 4772 4771 -1 |
zz-jason
reviewed
Mar 9, 2019
zz-jason
added
status/LGT2
|
@zz-jason We need to merge pingcap/parser#236 to update go.mod |
alivxxx
approved these changes
Mar 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix #9554
What is changed and how it works?
Let TiDB distinguish
over wandover(w)Check List
Tests