-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner/core: fix range info for the inner child of index join in explain
(#8058)
#9528
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zz-jason
added
contribution
This PR is from a community contributor.
sig/planner
SIG: Planner
labels
Mar 3, 2019
@jarvys Thanks! Please fix the CI. |
Hi, thanks for your contribution.
|
@winoros Thanks for code review! |
Codecov Report
@@ Coverage Diff @@
## master #9528 +/- ##
================================================
- Coverage 67.3963% 67.3722% -0.0242%
================================================
Files 374 374
Lines 78942 78994 +52
================================================
+ Hits 53204 53220 +16
- Misses 20986 21022 +36
Partials 4752 4752 |
Thanks for you contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix issue #8058 , fix range info for the inner child of index join.
What is changed and how it works?
Add two more fields
rangesWithFakeConds
andkeyOff2IdxOff
to structPhysicalIndexScan
. When theExplainInfo
method called, generate range info with these two fields, not only withrangeDecidedBy
.Check List
Tests
TestIssue8058
in cbo_test.goCode changes
Side effects
Related changes