Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: fix NO_ZERO_DATE handled incorrectly (#8765) #9407

Merged
merged 3 commits into from
Feb 21, 2019

Conversation

imtbkcat
Copy link

What problem does this PR solve?

cherry-pick #8765

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes

  • Has exported variable/fields change

@jackysp
Copy link
Member

jackysp commented Feb 21, 2019

/run-all-tests tidb-test=release-2.0 tidb-private-test=release-2.0 tikv=release-2.0

@imtbkcat
Copy link
Author

/run-all-tests tidb-test=release-2.1 tidb-private-test=release-2.1 tikv=release-2.1

@imtbkcat
Copy link
Author

/run-all-tests tidb-test=release-2.0 tidb-private-test=release-2.0 tikv=release-2.0

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added status/LGT2 Indicates that a PR has LGTM 2. and removed component/DDL-need-LGT3 labels Feb 21, 2019
@zimulala zimulala added status/LGT1 Indicates that a PR has LGTM 1. status/all tests passed and removed status/LGT2 Indicates that a PR has LGTM 2. status/all tests passed labels Feb 21, 2019
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp merged commit 21774e3 into pingcap:release-2.0 Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants