Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: start replacing logger with zap logger (#9279) #9316

Merged
merged 3 commits into from
Apr 1, 2019

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Feb 15, 2019

check-pick #9279 to v2.1
Relate to pingcap/tidb-test#737

@zimulala
Copy link
Contributor Author

/run-all-tests tidb-test=pr/737 tidb-private-test=release-2.1 tikv=release-2.1

@zz-jason
Copy link
Member

@zimulala Please resolve conflicts.

@zimulala
Copy link
Contributor Author

/run-all-tests tidb-test=pr/737 tidb-private-test=release-2.1 tikv=release-2.1

1 similar comment
@zimulala
Copy link
Contributor Author

zimulala commented Apr 1, 2019

/run-all-tests tidb-test=pr/737 tidb-private-test=release-2.1 tikv=release-2.1

Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 1, 2019
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 1, 2019
@zz-jason zz-jason merged commit 8d24954 into pingcap:release-2.1 Apr 1, 2019
@zimulala zimulala deleted the log branch April 2, 2019 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants