-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
correct config.toml.example #9313
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9313 +/- ##
==========================================
+ Coverage 67.19% 67.19% +<.01%
==========================================
Files 371 371
Lines 77531 77531
==========================================
+ Hits 52096 52099 +3
+ Misses 20784 20777 -7
- Partials 4651 4655 +4
Continue to review full report at Codecov.
|
PTAL @winkyao |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
# turn on this option when TiDB server is behind a proxy. | ||
compatible-kill-query = false | ||
# turn on this option when TiDB server is behind a proxy. (default true) | ||
# compatible-kill-query = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why change it?
also fixed in #9802 |
What problem does this PR solve?
the configuration
check-mb4-value-in-utf8
will never take effect inconf/config.toml.example
What is changed and how it works?
put
check-mb4-value-in-utf8
into right section of config file according to the syntax of the toml configuration fileCheck List
Tests
check-mb4-value-in-utf8 = false
Related changes