Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct config.toml.example #9313

Closed
wants to merge 3 commits into from
Closed

correct config.toml.example #9313

wants to merge 3 commits into from

Conversation

IANTHEREAL
Copy link
Contributor

What problem does this PR solve?

the configuration check-mb4-value-in-utf8 will never take effect in conf/config.toml.example

What is changed and how it works?

put check-mb4-value-in-utf8 into right section of config file according to the syntax of the toml configuration file

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    • create a config file, set check-mb4-value-in-utf8 = false
    • run tidb-server binary, check it takes effect

Related changes

  • Need to cherry-pick to the release branch

@IANTHEREAL IANTHEREAL added the type/bugfix This PR fixes a bug. label Feb 15, 2019
@codecov-io
Copy link

Codecov Report

Merging #9313 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9313      +/-   ##
==========================================
+ Coverage   67.19%   67.19%   +<.01%     
==========================================
  Files         371      371              
  Lines       77531    77531              
==========================================
+ Hits        52096    52099       +3     
+ Misses      20784    20777       -7     
- Partials     4651     4655       +4
Impacted Files Coverage Δ
ddl/delete_range.go 75.13% <0%> (-2.65%) ⬇️
executor/join.go 77.86% <0%> (-1.05%) ⬇️
executor/distsql.go 73% <0%> (+0.46%) ⬆️
store/tikv/coprocessor.go 62.92% <0%> (+2.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d4ad1f...7b963e8. Read the comment docs.

@tiancaiamao
Copy link
Contributor

PTAL @winkyao

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 15, 2019
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. component/server and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 15, 2019
@zz-jason
Copy link
Member

/run-all-tests

# turn on this option when TiDB server is behind a proxy.
compatible-kill-query = false
# turn on this option when TiDB server is behind a proxy. (default true)
# compatible-kill-query = true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change it?

@IANTHEREAL
Copy link
Contributor Author

also fixed in #9802

@IANTHEREAL IANTHEREAL closed this Jul 26, 2019
@IANTHEREAL IANTHEREAL deleted the correct-config-file branch July 26, 2019 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/server status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants