-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: handle Float32 for builtin function Values() #9215
Conversation
Signed-off-by: Jian Zhang <[email protected]>
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #9215 +/- ##
==========================================
- Coverage 67.22% 67.21% -0.01%
==========================================
Files 371 371
Lines 77050 77052 +2
==========================================
- Hits 51800 51794 -6
- Misses 20625 20631 +6
- Partials 4625 4627 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Jian Zhang [email protected]
What problem does this PR solve?
fix #8934
What is changed and how it works?
The builtin function
Values()
should get a floag32 value from the input Chunk when it's output type ismysql.TypeFloat
.Only
Column
andbuiltinValuesRealSig
callChunk.GetFloat64()
.Column
has handled the float32 input value correctly.Check List
Tests
Related changes