Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

table: check non-BMP characters and return error when the charset is utf8 and sql mode is strict mode (#8738) #8754

Merged
merged 3 commits into from
Dec 19, 2018

Conversation

winkyao
Copy link
Contributor

@winkyao winkyao commented Dec 19, 2018

What problem does this PR solve?

cherry-pick from #8738


This change is Reviewable

Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT2 Indicates that a PR has LGTM 2. label Dec 19, 2018
@zimulala
Copy link
Contributor

/run-all-tests tikv=release-2.1 pd=release-2.1 tidb-test=release-2.1

@winkyao
Copy link
Contributor Author

winkyao commented Dec 19, 2018

/run-all-tests tikv=release-2.1 pd=release-2.1 tidb-test=release-2.1

@winkyao winkyao merged commit 122d26b into pingcap:release-2.1 Dec 19, 2018
@winkyao winkyao deleted the release-2.1-cherry-pick branch December 19, 2018 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/server status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants