planner, executor: set memory size to MAXUint64 for prepare plan cache test #8556

XuHuaiyu · 2018-12-03T09:51:54Z

What problem does this PR solve?

Set memory size to MAXUint64 for prepare plan cache test

What is changed and how it works?

The test for prepare plan cache is unstable caused by the machine memory utilization after #8339 .
So I set the memory size to MAX_Uint64 to make the test result stable every time.

Check List

Tests

No code

Code changes
N/A

Side effects
N/A

Related changes
N/A

This change is

…e test

XuHuaiyu · 2018-12-03T09:52:55Z

PTAL @eurekaka @winoros

eurekaka

LGTM

eurekaka · 2018-12-03T10:33:38Z

/run-all-tests

dbjoa · 2018-12-03T10:38:24Z

executor/prepared_test.go

-		plannercore.PreparedPlanCacheMaxMemory, err = memory.MemTotal()
+		// PreparedPlanCacheMaxMemory is set to MAX_UINT64 to make sure the cache
+		// behavior would not be effected by the uncertain memory utilization.
+		plannercore.PreparedPlanCacheMaxMemory = math.MaxUint64
 		c.Assert(err, IsNil)


Would you remove the line of the error checking, which is related with memory.MemTotal()?

dbjoa · 2018-12-03T10:39:23Z

executor/prepared_test.go

-		plannercore.PreparedPlanCacheMaxMemory, err = memory.MemTotal()
+		// PreparedPlanCacheMaxMemory is set to MAX_UINT64 to make sure the cache
+		// behavior would not be effected by the uncertain memory utilization.
+		plannercore.PreparedPlanCacheMaxMemory = math.MaxUint64
 		c.Assert(err, IsNil)


dbjoa · 2018-12-03T10:39:44Z

executor/prepared_test.go

-		plannercore.PreparedPlanCacheMaxMemory, err = memory.MemTotal()
+		// PreparedPlanCacheMaxMemory is set to MAX_UINT64 to make sure the cache
+		// behavior would not be effected by the uncertain memory utilization.
+		plannercore.PreparedPlanCacheMaxMemory = math.MaxUint64
 		c.Assert(err, IsNil)


dbjoa · 2018-12-03T10:39:57Z

executor/prepared_test.go

-		plannercore.PreparedPlanCacheMaxMemory, err = memory.MemTotal()
+		// PreparedPlanCacheMaxMemory is set to MAX_UINT64 to make sure the cache
+		// behavior would not be effected by the uncertain memory utilization.
+		plannercore.PreparedPlanCacheMaxMemory = math.MaxUint64
 		c.Assert(err, IsNil)


dbjoa · 2018-12-03T10:40:08Z

executor/prepared_test.go

-		plannercore.PreparedPlanCacheMaxMemory, err = memory.MemTotal()
+		// PreparedPlanCacheMaxMemory is set to MAX_UINT64 to make sure the cache
+		// behavior would not be effected by the uncertain memory utilization.
+		plannercore.PreparedPlanCacheMaxMemory = math.MaxUint64
 		c.Assert(err, IsNil)


dbjoa · 2018-12-03T10:40:21Z

executor/prepared_test.go

-		plannercore.PreparedPlanCacheMaxMemory, err = memory.MemTotal()
+		// PreparedPlanCacheMaxMemory is set to MAX_UINT64 to make sure the cache
+		// behavior would not be effected by the uncertain memory utilization.
+		plannercore.PreparedPlanCacheMaxMemory = math.MaxUint64
 		c.Assert(err, IsNil)


dbjoa · 2018-12-03T10:40:33Z

executor/prepared_test.go

-		plannercore.PreparedPlanCacheMaxMemory, err = memory.MemTotal()
+		// PreparedPlanCacheMaxMemory is set to MAX_UINT64 to make sure the cache
+		// behavior would not be effected by the uncertain memory utilization.
+		plannercore.PreparedPlanCacheMaxMemory = math.MaxUint64
 		c.Assert(err, IsNil)


dbjoa · 2018-12-03T10:40:43Z

executor/prepared_test.go

-		plannercore.PreparedPlanCacheMaxMemory, err = memory.MemTotal()
+		// PreparedPlanCacheMaxMemory is set to MAX_UINT64 to make sure the cache
+		// behavior would not be effected by the uncertain memory utilization.
+		plannercore.PreparedPlanCacheMaxMemory = math.MaxUint64
 		c.Assert(err, IsNil)


dbjoa · 2018-12-03T10:40:53Z

executor/prepared_test.go

-	plannercore.PreparedPlanCacheMaxMemory, err = memory.MemTotal()
+	// PreparedPlanCacheMaxMemory is set to MAX_UINT64 to make sure the cache
+	// behavior would not be effected by the uncertain memory utilization.
+	plannercore.PreparedPlanCacheMaxMemory = math.MaxUint64
 	c.Assert(err, IsNil)


dbjoa · 2018-12-03T10:41:06Z

planner/core/point_get_plan_test.go

-	core.PreparedPlanCacheMaxMemory, err = memory.MemTotal()
+	// PreparedPlanCacheMaxMemory is set to MAX_UINT64 to make sure the cache
+	// behavior would not be effected by the uncertain memory utilization.
+	core.PreparedPlanCacheMaxMemory = math.MaxUint64
 	c.Assert(err, IsNil)


dbjoa · 2018-12-03T10:41:18Z

planner/core/prepare_test.go

-	core.PreparedPlanCacheMaxMemory, err = memory.MemTotal()
+	// PreparedPlanCacheMaxMemory is set to MAX_UINT64 to make sure the cache
+	// behavior would not be effected by the uncertain memory utilization.
+	core.PreparedPlanCacheMaxMemory = math.MaxUint64
 	c.Assert(err, IsNil)


dbjoa · 2018-12-03T10:41:30Z

planner/core/prepare_test.go

-	core.PreparedPlanCacheMaxMemory, err = memory.MemTotal()
+	// PreparedPlanCacheMaxMemory is set to MAX_UINT64 to make sure the cache
+	// behavior would not be effected by the uncertain memory utilization.
+	core.PreparedPlanCacheMaxMemory = math.MaxUint64
 	c.Assert(err, IsNil)


dbjoa · 2018-12-03T10:41:41Z

planner/core/prepare_test.go

-	core.PreparedPlanCacheMaxMemory, err = memory.MemTotal()
+	// PreparedPlanCacheMaxMemory is set to MAX_UINT64 to make sure the cache
+	// behavior would not be effected by the uncertain memory utilization.
+	core.PreparedPlanCacheMaxMemory = math.MaxUint64
 	c.Assert(err, IsNil)


dbjoa · 2018-12-03T10:41:50Z

planner/core/prepare_test.go

-	core.PreparedPlanCacheMaxMemory, err = memory.MemTotal()
+	// PreparedPlanCacheMaxMemory is set to MAX_UINT64 to make sure the cache
+	// behavior would not be effected by the uncertain memory utilization.
+	core.PreparedPlanCacheMaxMemory = math.MaxUint64
 	c.Assert(err, IsNil)


…che_test

XuHuaiyu · 2018-12-03T10:50:04Z

PTAL @dbjoa @winoros

dbjoa · 2018-12-03T10:53:04Z

LGTM

dbjoa · 2018-12-03T10:54:47Z

Please fix CI errors.

XuHuaiyu · 2018-12-03T11:26:54Z

/run-integration-ddl-test

XuHuaiyu · 2018-12-03T13:04:33Z

PTAL @winoros @zz-jason

zz-jason

LGTM

zz-jason · 2018-12-03T13:58:34Z

CI failed:

executor/prepared_test.go:710:49: undefined: memory

…u/cache_test

zz-jason

LGTM

…e test (pingcap#8556)

planner, executor: set memory size to MAXUint64 for prepare plan cach…

86d264c

…e test

XuHuaiyu added type/enhancement The issue or PR belongs to an enhancement. component/test labels Dec 3, 2018

eurekaka reviewed Dec 3, 2018

View reviewed changes

Merge branch 'master' into cache_test

3772c6b

eurekaka added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 3, 2018

dbjoa reviewed Dec 3, 2018

View reviewed changes

XuHuaiyu added 3 commits December 3, 2018 18:48

address comment

f5a39d8

Merge branch 'master' of https://github.com/pingcap/tidb into cache_test

98ad364

Merge branch 'cache_test' of https://github.com/XuHuaiyu/tidb into ca…

3a6fb98

…che_test

fix ci

fcacd45

XuHuaiyu added the status/all tests passed label Dec 3, 2018

zz-jason previously approved these changes Dec 3, 2018

View reviewed changes

Merge branch 'master' into cache_test

1d89678

zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 3, 2018

XuHuaiyu added 2 commits December 4, 2018 10:19

address commet

a709b6b

Merge branch 'master' of https://github.com/pingcap/tidb into XuHuaiy…

1a45686

…u/cache_test

XuHuaiyu dismissed zz-jason’s stale review via 1a45686 December 4, 2018 02:26

Merge branch 'master' into cache_test

d3ccad8

zz-jason approved these changes Dec 4, 2018

View reviewed changes

XuHuaiyu merged commit cbae4c6 into pingcap:master Dec 4, 2018

XuHuaiyu deleted the cache_test branch December 4, 2018 02:53

iamzhoug37 pushed a commit to iamzhoug37/tidb that referenced this pull request Dec 13, 2018

planner, executor: set memory size to MAXUint64 for prepare plan cach…

a166396

…e test (pingcap#8556)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

planner, executor: set memory size to MAXUint64 for prepare plan cache test #8556

planner, executor: set memory size to MAXUint64 for prepare plan cache test #8556

XuHuaiyu commented Dec 3, 2018 •

edited by c4pt0r

Loading

XuHuaiyu commented Dec 3, 2018

eurekaka left a comment

eurekaka commented Dec 3, 2018

dbjoa Dec 3, 2018

dbjoa Dec 3, 2018

dbjoa Dec 3, 2018

dbjoa Dec 3, 2018

dbjoa Dec 3, 2018

dbjoa Dec 3, 2018

dbjoa Dec 3, 2018

dbjoa Dec 3, 2018

dbjoa Dec 3, 2018

dbjoa Dec 3, 2018

dbjoa Dec 3, 2018

dbjoa Dec 3, 2018

dbjoa Dec 3, 2018

dbjoa Dec 3, 2018

XuHuaiyu commented Dec 3, 2018

dbjoa commented Dec 3, 2018

dbjoa commented Dec 3, 2018

XuHuaiyu commented Dec 3, 2018

XuHuaiyu commented Dec 3, 2018

zz-jason left a comment

zz-jason commented Dec 3, 2018

zz-jason left a comment

planner, executor: set memory size to MAXUint64 for prepare plan cache test #8556

planner, executor: set memory size to MAXUint64 for prepare plan cache test #8556

Conversation

XuHuaiyu commented Dec 3, 2018 • edited by c4pt0r Loading

What problem does this PR solve?

What is changed and how it works?

Check List

XuHuaiyu commented Dec 3, 2018

eurekaka left a comment

Choose a reason for hiding this comment

eurekaka commented Dec 3, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

XuHuaiyu commented Dec 3, 2018

dbjoa commented Dec 3, 2018

dbjoa commented Dec 3, 2018

XuHuaiyu commented Dec 3, 2018

XuHuaiyu commented Dec 3, 2018

zz-jason left a comment

Choose a reason for hiding this comment

zz-jason commented Dec 3, 2018

zz-jason left a comment

Choose a reason for hiding this comment

XuHuaiyu commented Dec 3, 2018 •

edited by c4pt0r

Loading