*: Txn() function signature refactor and remove ActivePendingTxn() #8327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* change Txn() function signature to Txn(active bool) * ActivePendingTxn() is not used any more because Txn() does the work
jackysp
reviewed
Nov 15, 2018
| @@ -207,8 +207,6 @@ func (e *ExecuteExec) Build() error { | |||
| var err error | |||
| if IsPointGetWithPKOrUniqueKeyByAutoCommit(e.ctx, e.plan) { | |||
| err = e.ctx.InitTxnWithStartTS(math.MaxUint64) | |||
| } else { | |||
| err = e.ctx.ActivePendingTxn() | |||
There was a problem hiding this comment.
I think, yes, Prepared Executor is forgot
https://github.com/pingcap/tidb/pull/8260/files#diff-350127760839dbfd52d23927f7ff2d95L290
tiancaiamao
added
the
type/enhancement
|
/run-all-tests |
zz-jason
approved these changes
Nov 15, 2018
|
/run-all-tests |
|
/run-all-tests tidb-test=pr/650 |
|
/run-integration-ddl-test tidb-test=pr/650 |
|
/run-build |
|
I can not get the point of this PR. And for the Tests, why do you say "No code". There are a bunch of code changes. |
|
/run-integration-ddl-test tidb-test=pr/650 |
|
/rebuild |
|
/run-all-tests tidb-test=pr/650 |
|
/run-integration-ddl-test tidb-test=pr/650 |
tiancaiamao
added a commit
to tiancaiamao/tidb
that referenced
this pull request
Dec 4, 2018
…ingcap#8327) * change Txn() function signature to Txn(active bool) * ActivePendingTxn() is not used any more because Txn() does the work * change executor builder getStartTS() uint64 to getStartTS() (uint64, error)
tiancaiamao
added a commit
to tiancaiamao/tidb
that referenced
this pull request
Dec 4, 2018
jackysp
pushed a commit
that referenced
this pull request
Dec 5, 2018
zz-jason
pushed a commit
that referenced
this pull request
Dec 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Clean up after #8260
What is changed and how it works?
Txn()function signature toTxn(active bool)ActivePendingTxn()is not used any more becauseTxn()does the workgetStartTS() uint64togetStartTS() (uint64, error)Check List
Tests
@zz-jason @jackysp @zimulala @winkyao