Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: bump grpc to 1.12.2 #7865

Merged
merged 2 commits into from
Oct 11, 2018
Merged

*: bump grpc to 1.12.2 #7865

merged 2 commits into from
Oct 11, 2018

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Oct 10, 2018

What problem does this PR solve?

Fix data race in grpc 1.12.0. The detailed information can be found in tikv/pd#1264.

What is changed and how it works?

This PR bumps grpc to 1.12.2.

Check List

Tests

  • No code

@winkyao
Copy link
Contributor

winkyao commented Oct 10, 2018

/run-all-tests

@winkyao
Copy link
Contributor

winkyao commented Oct 11, 2018

@rleungx How you do manual test, could you show us more details?

@rleungx
Copy link
Member Author

rleungx commented Oct 11, 2018

@winkyao Oh, sorry for that, I have edited the description of this PR.

@zz-jason zz-jason added contribution This PR is from a community contributor. and removed contribution This PR is from a community contributor. labels Oct 11, 2018
@zz-jason
Copy link
Member

LGTM

@zz-jason
Copy link
Member

@jackysp @tiancaiamao PTAL

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 11, 2018
@tiancaiamao
Copy link
Contributor

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 11, 2018
@zz-jason zz-jason merged commit e442d9a into pingcap:master Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants