store/gc_worker: Use UnsafeDestroyRange instead of DeleteRange in GC #7560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's better to separate the modification of vendor to another pr. |
|
Oh, yes. It may be separated out from this PR later. |
Signed-off-by: MyonKeminta <[email protected]>
Signed-off-by: MyonKeminta <[email protected]>
MyonKeminta
changed the title
Signed-off-by: MyonKeminta <[email protected]>
Signed-off-by: MyonKeminta <[email protected]>
Signed-off-by: MyonKeminta <[email protected]>
Signed-off-by: MyonKeminta <[email protected]>
Signed-off-by: MyonKeminta <[email protected]>
Signed-off-by: MyonKeminta <[email protected]>
Signed-off-by: MyonKeminta <[email protected]>
|
@tiancaiamao PTAL thanks! |
MyonKeminta
changed the title
|
/run-integration-tests |
coocood
reviewed
Sep 14, 2018
store/tikv/gcworker/gc_worker.go
Outdated
| metrics.GCWorkerCounter.WithLabelValues("re_delete_range").Inc() | ||
|
|
||
| // We check delete range records that are deleted about 24 hours ago. | ||
| safePointTime := oracle.PhysicalToTime(oracle.ExtractPhysical(safePoint)) |
There was a problem hiding this comment.
I think calculation on the TS directly is simpler, may need to extract the constant.
reDeleteTs := safepoint + oracle.ComposePhysical(24 * 60 * 60 * 1000), 0)
Signed-off-by: MyonKeminta <[email protected]>
|
/run-all-tests |
|
LGTM |
|
/run-unit-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This PR tries to solve the problem that the third step of GC, DeleteRanges, is too slow.
What is changed and how it works?
GetAllStoresfunction to PdClientdelete_range_donetable and pick ranges deleted 24 hours again, and call DestroyRange againThe idea is detailed recorded in tikv/rfcs#2
This PR should not be merged before tikv/tikv#3560
Check List
Tests
Code changes
Side effects