fix compatibility bug with convert string to int return wrong result #7483
Conversation
|
Hi contributor, thanks for your PR. This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically. |
types/convert.go
Outdated
| @@ -275,7 +275,8 @@ func floatStrToIntStr(validFloat string) (string, error) { | |||
| } | |||
| if exp > 0 && int64(intCnt) > (math.MaxInt64-int64(exp)) { | |||
| // (exp + incCnt) overflows MaxInt64. | |||
| return validFloat, ErrOverflow.GenByArgs("BIGINT", validFloat) | |||
| sc.AppendError(ErrOverflow.GenByArgs("BIGINT", oriStr)) | |||
There was a problem hiding this comment.
This means the previous error message is wrong?
There was a problem hiding this comment.
yes, the error message in this case is like below
mysql> show warnings;
+---------+------+-------------------------------------------------+
| Level | Code | Message |
+---------+------+-------------------------------------------------+
| Warning | 1292 | Truncated incorrect INTEGER value: '125e342.83' |
+---------+------+-------------------------------------------------+
There was a problem hiding this comment.
So why AppendError? Shouldn't we AppendWarning?
There was a problem hiding this comment.
yes, it's should be AppendWarning. Already Fixed
types/convert.go
Outdated
| @@ -292,7 +293,8 @@ func floatStrToIntStr(validFloat string) (string, error) { | |||
| extraZeroCount := intCnt - len(digits) | |||
| if extraZeroCount > 20 { | |||
| // Return overflow to avoid allocating too much memory. | |||
There was a problem hiding this comment.
@CodeRushing Please update this comment.
There was a problem hiding this comment.
@zz-jason already updated
zz-jason
added
type/compatibility
status/LGT1
|
/run-all-tests |
What problem does this PR solve?
fix the issue#7398
What is changed and how it works?
In types.floatStrToIntStr function, when extraZeroCount or intCnt overflows, just AppendWarning and return nil error
Check List
Tests