ddl: add COMMENTS column to DDL jobs and enhance job reorg meta handling

[tangenta]

What problem does this PR solve?

Issue Number: ref #57229 #57526

Problem Summary: See #57229

What changed and how does it work?

• Add COMMENTS column to ADMIN SHOW DDL JOBS.
• Refine DDL job reorg meta initialization. For example, let "modify column"/"reorg partition" and other reorg DDL types utilize ReorgMeta.Concurrency and ReorgMeta.BatchSize.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

add COMMENTS column to ADMIN SHOW DDL JOBS

[tiprow]

Hi @tangenta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

Attention: Patch coverage is 80.62500% with 31 lines in your changes missing coverage. Please review.

Project coverage is 74.6542%. Comparing base (aeed37b) to head (aec1d68).
Report is 69 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #57392        +/-   ##
================================================
+ Coverage   72.8693%   74.6542%   +1.7849%     
================================================
  Files          1672       1721        +49     
  Lines        461965     485455     +23490     
================================================
+ Hits         336631     362413     +25782     
+ Misses       104569     100614      -3955     
- Partials      20765      22428      +1663     

Flag	Coverage Δ
integration	49.3437% <51.2500%> (?)
unit	72.2759% <79.3750%> (+0.0270%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.7673% <ø> (ø)
parser	∅ <ø> (∅)
br	58.2397% <ø> (+13.1109%)	⬆️

---- 🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[CbcWestwolf]

LGTM
Please fix the broken UT and realtikvtest

[tangenta]

/retest

[tiprow]

@tangenta: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[fzzf678]

/retest

[tiprow]

@tangenta: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[tangenta]

/retest

[tiprow]

@tangenta: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[tangenta]

/retest

[tiprow]

@tangenta: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CbcWestwolf, fzzf678, hawkingrei, wjhuang2016, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [CbcWestwolf,YuJuncen,hawkingrei,wjhuang2016]
• br/OWNERS [YuJuncen]
• pkg/ddl/OWNERS [wjhuang2016]
• pkg/meta/OWNERS [wjhuang2016]
• pkg/planner/OWNERS [hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[fzzf678]

/retest

[tiprow]

@fzzf678: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[tangenta]

/retest

[tiprow]

@tangenta: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[tangenta]

/retest

[fzzf678]

/retest

[tiprow]

@fzzf678: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[tiprow]

@tangenta: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[fzzf678]

/retest

[tiprow]

@fzzf678: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-8.5: #57595.