-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: support modify the related reorg config by SQL #57336
Conversation
Hi @fzzf678. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #57336 +/- ##
================================================
+ Coverage 72.9011% 74.7991% +1.8979%
================================================
Files 1668 1717 +49
Lines 461134 474380 +13246
================================================
+ Hits 336172 354832 +18660
+ Misses 104308 97337 -6971
- Partials 20654 22211 +1557
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Co-authored-by: tangenta <[email protected]>
[LGTM Timeline notifier]Timeline:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CbcWestwolf, tangenta, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@fzzf678: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retest |
@fzzf678: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/hold |
/unhold |
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: ref #57229 #57526
Problem Summary:
What changed and how does it work?
For the purpose of dynamically adjusting reorg configs, we need to persist the config value to disk, so in this pr, we support modify reorg config in system table by execute sql
ADMIN ALTER DDL JOBS ...
. OnlyADD INDEX
,MODIFY COLUMN
, andREORGANIZE PARTITION
three types ddl is allowed to change config. And for config we supportTHREAD
,BATCH_SIZE
andMAX_WRITE_SPEED
now.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.