Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: support modify the related reorg config by SQL #57336

Merged
merged 25 commits into from
Nov 15, 2024

Conversation

fzzf678
Copy link
Contributor

@fzzf678 fzzf678 commented Nov 13, 2024

What problem does this PR solve?

Issue Number: ref #57229 #57526

Problem Summary:

What changed and how does it work?

For the purpose of dynamically adjusting reorg configs, we need to persist the config value to disk, so in this pr, we support modify reorg config in system table by execute sql ADMIN ALTER DDL JOBS .... Only ADD INDEX, MODIFY COLUMN, and REORGANIZE PARTITION three types ddl is allowed to change config. And for config we support THREAD, BATCH_SIZE and MAX_WRITE_SPEED now.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 13, 2024
Copy link

tiprow bot commented Nov 13, 2024

Hi @fzzf678. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 81.29496% with 26 lines in your changes missing coverage. Please review.

Project coverage is 74.7991%. Comparing base (a5832b4) to head (4e07161).
Report is 72 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #57336        +/-   ##
================================================
+ Coverage   72.9011%   74.7991%   +1.8979%     
================================================
  Files          1668       1717        +49     
  Lines        461134     474380     +13246     
================================================
+ Hits         336172     354832     +18660     
+ Misses       104308      97337      -6971     
- Partials      20654      22211      +1557     
Flag Coverage Δ
integration 49.2092% <18.7050%> (?)
unit 72.2789% <81.2949%> (-0.0058%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7673% <ø> (ø)
parser ∅ <ø> (∅)
br 60.5282% <ø> (+15.4189%) ⬆️
---- 🚨 Try these New Features:

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 14, 2024
@fzzf678 fzzf678 requested a review from winoros November 14, 2024 08:46
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 14, 2024
Copy link

ti-chi-bot bot commented Nov 14, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-14 02:20:15.807510501 +0000 UTC m=+495577.998379498: ☑️ agreed by tangenta.
  • 2024-11-14 09:12:41.358004529 +0000 UTC m=+520323.548873525: ☑️ agreed by CbcWestwolf.

Copy link

ti-chi-bot bot commented Nov 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CbcWestwolf, tangenta, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 14, 2024
@fzzf678
Copy link
Contributor Author

fzzf678 commented Nov 15, 2024

/retest

Copy link

tiprow bot commented Nov 15, 2024

@fzzf678: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@fzzf678
Copy link
Contributor Author

fzzf678 commented Nov 15, 2024

/retest

Copy link

tiprow bot commented Nov 15, 2024

@fzzf678: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@fzzf678
Copy link
Contributor Author

fzzf678 commented Nov 15, 2024

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 15, 2024
@fzzf678
Copy link
Contributor Author

fzzf678 commented Nov 15, 2024

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 15, 2024
@ti-chi-bot ti-chi-bot bot merged commit afacd10 into pingcap:master Nov 15, 2024
26 checks passed
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Nov 20, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #57529.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants