ddl: args v2 for Alter/Remove Partitioning and Add/Drop/Reorganize Partition #56163

D3Hunter · 2024-09-19T10:47:28Z

What problem does this PR solve?

Issue Number: ref #53930

Problem Summary:

What changed and how does it work?

as title

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

tiprow · 2024-09-19T10:47:45Z

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

codecov · 2024-09-19T11:13:39Z

Codecov Report

Attention: Patch coverage is 79.01235% with 34 lines in your changes missing coverage. Please review.

Project coverage is 56.9996%. Comparing base (6bdf685) to head (0d1cb19).
Report is 4 commits behind head on master.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #56163         +/-   ##
=================================================
- Coverage   73.4187%   56.9996%   -16.4191%     
=================================================
  Files          1600       1758        +158     
  Lines        443647     631472     +187825     
=================================================
+ Hits         325720     359937      +34217     
- Misses        97964     246943     +148979     
- Partials      19963      24592       +4629

Flag	Coverage Δ
integration	`39.5695% <67.2839%> (?)`
unit	`72.6894% <79.0123%> (+0.2037%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.9567% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`63.2037% <ø> (+17.3141%)`	⬆️

D3Hunter · 2024-09-19T13:45:08Z

/retest

tiprow · 2024-09-19T13:45:30Z

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

joccau

rest lgtm.

joccau · 2024-09-20T03:17:19Z

pkg/ddl/rollingback.go

 	} else {
-		job.Args = []any{partNames}
+		args.PartNames = partNames
+		model.FillRollbackArgsForAddPartition(job, args)


Why not job.FillArgs(args) directly ?

see comments on TablePartitionArgs, it changes param order and type in this case

joccau

LGTM

ti-chi-bot · 2024-09-20T07:31:51Z

[LGTM Timeline notifier]

Timeline:

2024-09-20 06:29:46.374419179 +0000 UTC m=+1201856.114843314: ☑️ agreed by joccau.
2024-09-20 07:31:50.805241447 +0000 UTC m=+1205580.545665402: ☑️ agreed by lance6716.

ti-chi-bot · 2024-09-20T08:01:18Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joccau, lance6716, Leavrth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [Leavrth,joccau,lance6716]
~~br/OWNERS~~ [Leavrth]
~~pkg/ddl/OWNERS~~ [lance6716]
~~pkg/meta/OWNERS~~ [lance6716]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

D3Hunter · 2024-09-20T09:54:07Z

/retest

tiprow · 2024-09-20T09:54:30Z

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

D3Hunter · 2024-09-20T12:47:44Z

/retest

tiprow · 2024-09-20T12:48:06Z

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

D3Hunter · 2024-09-20T15:06:46Z

/retest

tiprow · 2024-09-20T15:07:14Z

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

…rtition (pingcap#56163) ref pingcap#53930

change

a2ccab8

ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 19, 2024

change

63706e0

change

50a2902

D3Hunter added 3 commits September 19, 2024 22:58

change

8742281

Merge remote-tracking branch 'upstream/master' into argsv2-partition

bffe539

bazel

6e1e48d

D3Hunter changed the title ~~[WIP]ddl: args v2 for Alter/Remove Partitioning and Add/Drop/Reorganize Partition~~ ddl: args v2 for Alter/Remove Partitioning and Add/Drop/Reorganize Partition Sep 19, 2024

ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 19, 2024

D3Hunter requested a review from lance6716 September 20, 2024 01:54

joccau reviewed Sep 20, 2024

View reviewed changes

joccau approved these changes Sep 20, 2024

View reviewed changes

ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 20, 2024

lance6716 approved these changes Sep 20, 2024

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 20, 2024

Leavrth approved these changes Sep 20, 2024

View reviewed changes

ti-chi-bot bot added the approved label Sep 20, 2024

Merge remote-tracking branch 'upstream/master' into argsv2-partition

0d1cb19

mjonss mentioned this pull request Sep 20, 2024

ddl: Reorganize Partition failure/rollback tests and fixes #53544

Merged

13 tasks

ti-chi-bot bot merged commit 2651b77 into pingcap:master Sep 20, 2024
23 checks passed

D3Hunter deleted the argsv2-partition branch September 20, 2024 17:33

This was referenced Sep 23, 2024

ddl: fix panic in TablePartitionArgs v2 #56222

Merged

ddl code refactor/optimize #54436

Open

winoros pushed a commit to winoros/tidb that referenced this pull request Sep 23, 2024

ddl: args v2 for Alter/Remove Partitioning and Add/Drop/Reorganize Pa…

3fd5e5f

…rtition (pingcap#56163) ref pingcap#53930

D3Hunter mentioned this pull request Oct 14, 2024

improve the usability of DDL Job.Args #53930

Closed

26 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ddl: args v2 for Alter/Remove Partitioning and Add/Drop/Reorganize Partition #56163

ddl: args v2 for Alter/Remove Partitioning and Add/Drop/Reorganize Partition #56163

D3Hunter commented Sep 19, 2024

tiprow bot commented Sep 19, 2024

codecov bot commented Sep 19, 2024 •

edited

Loading

D3Hunter commented Sep 19, 2024

tiprow bot commented Sep 19, 2024

joccau left a comment

joccau Sep 20, 2024

D3Hunter Sep 20, 2024

joccau left a comment

ti-chi-bot bot commented Sep 20, 2024

ti-chi-bot bot commented Sep 20, 2024

D3Hunter commented Sep 20, 2024

tiprow bot commented Sep 20, 2024

D3Hunter commented Sep 20, 2024

tiprow bot commented Sep 20, 2024

D3Hunter commented Sep 20, 2024

tiprow bot commented Sep 20, 2024

ddl: args v2 for Alter/Remove Partitioning and Add/Drop/Reorganize Partition #56163

ddl: args v2 for Alter/Remove Partitioning and Add/Drop/Reorganize Partition #56163

Conversation

D3Hunter commented Sep 19, 2024

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

tiprow bot commented Sep 19, 2024

codecov bot commented Sep 19, 2024 • edited Loading

Codecov Report

D3Hunter commented Sep 19, 2024

tiprow bot commented Sep 19, 2024

joccau left a comment

Choose a reason for hiding this comment

joccau Sep 20, 2024

Choose a reason for hiding this comment

D3Hunter Sep 20, 2024

Choose a reason for hiding this comment

joccau left a comment

Choose a reason for hiding this comment

ti-chi-bot bot commented Sep 20, 2024

[LGTM Timeline notifier]

ti-chi-bot bot commented Sep 20, 2024

D3Hunter commented Sep 20, 2024

tiprow bot commented Sep 20, 2024

D3Hunter commented Sep 20, 2024

tiprow bot commented Sep 20, 2024

D3Hunter commented Sep 20, 2024

tiprow bot commented Sep 20, 2024

codecov bot commented Sep 19, 2024 •

edited

Loading