planner: fix the issue of reusing wrong point-plan for "select ... for update" (#54661)

[qw4990]

This is an automated cherry-pick of #54661

What problem does this PR solve?

Issue Number: close #54652

Problem Summary: planner: fix the issue of reusing wrong point-plan for "select ... for update"

What changed and how does it work?

Encode more txn state into the plan cache key, and check whether the key has changed before reusing point-get plans.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[qw4990]

/ok-to-test

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-08-01 06:36:43.175597936 +0000 UTC m=+424119.455646007: ☑️ agreed by AilinKid.
• 2024-08-01 06:36:49.10017838 +0000 UTC m=+424125.380226444: ☑️ agreed by hawkingrei.

[hawkingrei]

/test all

[tiprow]

@hawkingrei: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[fixdb]

+1

[wuhuizuo]

/retest

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, fixdb, hawkingrei, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [AilinKid,fixdb,hawkingrei,wjhuang2016]
• pkg/ddl/OWNERS [wjhuang2016]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[qw4990]

/retest

[wuhuizuo]

/retest

[codecov]

Codecov Report

Attention: Patch coverage is 85.00000% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.1@45fd6e5). Learn more about missing BASE report.

Additional details and impacted files

@@               Coverage Diff                @@
##             release-8.1     #55124   +/-   ##
================================================
  Coverage               ?   71.4318%           
================================================
  Files                  ?       1487           
  Lines                  ?     430339           
  Branches               ?          0           
================================================
  Hits                   ?     307399           
  Misses                 ?     101724           
  Partials               ?      21216           

Flag	Coverage Δ
integration	53.0419% <ø> (?)
unit	71.1538% <85.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	53.9957% <0.0000%> (?)
parser	∅ <0.0000%> (?)
br	41.1149% <0.0000%> (?)

[qw4990]

/retest