Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: refactor the BaseExecutor and remove session context in ProjectionExec #54614

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

YangKeao
Copy link
Member

What problem does this PR solve?

Issue Number: close #54613

Problem Summary:

Similar to #51397. This PR uses the BaseExecutorV2 and removed the session context in the ProjectionExec.

What changed and how does it work?

  1. Remove the BaseExecutor internal and replace it with BaseExecutorV2.
  2. Add a new projectionExecutorContext, which includes all information needed by the projection executor.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.
      No logic change. It shouldn't break existing tests.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 15, 2024
@YangKeao YangKeao force-pushed the support-projection branch from e853ebf to 1ef0fa9 Compare July 15, 2024 06:11
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.8487%. Comparing base (ac786cb) to head (1ef0fa9).
Report is 17 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #54614         +/-   ##
=================================================
- Coverage   72.7696%   55.8487%   -16.9210%     
=================================================
  Files          1549       1672        +123     
  Lines        436487     612383     +175896     
=================================================
+ Hits         317630     342008      +24378     
- Misses        99294     247004     +147710     
- Partials      19563      23371       +3808     
Flag Coverage Δ
integration 37.1833% <100.0000%> (?)
unit 71.7433% <100.0000%> (-0.0519%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <ø> (ø)
parser ∅ <ø> (∅)
br 52.5609% <ø> (+6.7103%) ⬆️

@YangKeao
Copy link
Member Author

/retest

@YangKeao YangKeao requested review from lcwangchao and xhebox July 16, 2024 02:12
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 16, 2024
Copy link

ti-chi-bot bot commented Jul 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lcwangchao, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 17, 2024
Copy link

ti-chi-bot bot commented Jul 17, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-16 02:14:50.54881434 +0000 UTC m=+320112.539755811: ☑️ agreed by xhebox.
  • 2024-07-17 03:29:09.578081324 +0000 UTC m=+410971.569022789: ☑️ agreed by lcwangchao.

@ti-chi-bot ti-chi-bot bot merged commit b5bbbf4 into pingcap:master Jul 17, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor the BaseExecutor in ProjectionExec
3 participants