Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: turn on coarse-grained as default for restore #51830

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

BornChanger
Copy link
Contributor

@BornChanger BornChanger commented Mar 15, 2024

What problem does this PR solve?

Issue Number: ref #50701 closes #52114

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 15, 2024
Copy link

tiprow bot commented Mar 15, 2024

Hi @BornChanger. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BornChanger
Copy link
Contributor Author

/cc @3pointer @Leavrth

@ti-chi-bot ti-chi-bot bot requested review from 3pointer and Leavrth March 15, 2024 10:46
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Merging #51830 (8403dcd) into master (e4dc2c9) will decrease coverage by 15.2770%.
Report is 101 commits behind head on master.
The diff coverage is 0.0000%.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #51830         +/-   ##
=================================================
- Coverage   70.7233%   55.4464%   -15.2770%     
=================================================
  Files          1476       1596        +120     
  Lines        438138     629673     +191535     
=================================================
+ Hits         309866     349131      +39265     
- Misses       108844     256724     +147880     
- Partials      19428      23818       +4390     
Flag Coverage Δ
integration 38.6755% <0.0000%> (?)
unit 70.4642% <0.0000%> (-0.0653%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.8976% <0.0000%> (+5.9895%) ⬆️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 18, 2024
@BornChanger
Copy link
Contributor Author

/type cherry-pick-for-release-8.0

Copy link

ti-chi-bot bot commented Mar 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, Leavrth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 26, 2024
Copy link

ti-chi-bot bot commented Mar 26, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-18 06:27:19.934088407 +0000 UTC m=+1271666.956334795: ☑️ agreed by Leavrth.
  • 2024-03-26 09:53:01.626777842 +0000 UTC m=+1975208.649024254: ☑️ agreed by 3pointer.

@BornChanger
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Mar 26, 2024

@BornChanger: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BornChanger
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Mar 26, 2024

@BornChanger: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit 8428e38 into pingcap:master Mar 26, 2024
36 of 47 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.0: #52113.

ti-chi-bot bot pushed a commit that referenced this pull request Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-8.0 release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

br: turn on coarse-grained for full restore
4 participants