-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
table: fix issue of get default value from column when column doesn't have default value | tidb-test=pr/2305 #51309
Conversation
…efaultValueFlag Signed-off-by: crazycs520 <[email protected]>
Hi @crazycs520. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #51309 +/- ##
================================================
+ Coverage 70.6521% 72.7401% +2.0880%
================================================
Files 1461 1462 +1
Lines 434859 435586 +727
================================================
+ Hits 307237 316846 +9609
+ Misses 108346 98794 -9552
- Partials 19276 19946 +670
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: crazycs520 <[email protected]>
Signed-off-by: crazycs520 <[email protected]>
[LGTM Timeline notifier]Timeline:
|
Signed-off-by: crazycs520 <[email protected]>
/hold , Since I may found other bug. |
Signed-off-by: crazycs520 <[email protected]>
Signed-off-by: crazycs520 <[email protected]>
Signed-off-by: crazycs520 <[email protected]>
…0043 Signed-off-by: crazycs520 <[email protected]>
…0043 Signed-off-by: crazycs520 <[email protected]>
Signed-off-by: crazycs520 <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Defined2014, lcwangchao, zimulala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
What problem does this PR solve?
Issue Number: close #50043, close #51324
Problem Summary:
What changed and how does it work?
This PR reverts some changes introduced by #35072 and use another way to check
ErrNoDefaultValue
before insert.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.