Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore: fix choose the emptry key as split key (#50478) #50518

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #50478

What problem does this PR solve?

Issue Number: close #50471 #50477

Problem Summary:

  1. new split approach will choose empty key in some case. this PR tried to fix it.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.6 labels Jan 17, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 17, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jan 17, 2024
Copy link

ti-chi-bot bot commented Jan 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, Leavrth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 17, 2024
Copy link

ti-chi-bot bot commented Jan 17, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-17 12:28:26.072112738 +0000 UTC m=+358947.636410443: ☑️ agreed by BornChanger.
  • 2024-01-17 12:39:21.938566718 +0000 UTC m=+359603.502864422: ☑️ agreed by Leavrth.

@BornChanger
Copy link
Contributor

/retest

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-7.6@6c576f9). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.6     #50518   +/-   ##
================================================
  Coverage               ?   70.0209%           
================================================
  Files                  ?       1436           
  Lines                  ?     419263           
  Branches               ?          0           
================================================
  Hits                   ?     293572           
  Misses                 ?     105389           
  Partials               ?      20302           
Flag Coverage Δ
unit 70.0209% <0.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0269% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 49.6778% <0.0000%> (?)

@BornChanger
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot merged commit c4df22d into pingcap:release-7.6 Jan 17, 2024
27 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants