planner: avoid to use ScalarFunction.GetCtx in some planner codes
#48794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
do-not-merge/needs-tests-checked
release-note-none
ti-chi-bot
bot
added
the
size/M
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #48794 +/- ##
================================================
+ Coverage 71.0271% 72.7250% +1.6979%
================================================
Files 1367 1392 +25
Lines 404903 411865 +6962
================================================
+ Hits 287591 299529 +11938
+ Misses 97306 93461 -3845
+ Partials 20006 18875 -1131
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lcwangchao
force-pushed
the
planner_getctx
branch
from
001b6ad to
49c7261
Compare
|
/retest |
ti-chi-bot
bot
added
size/XXL
|
/retest |
1 similar comment
|
/retest |
qw4990
approved these changes
Nov 24, 2023
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
XuHuaiyu
approved these changes
Nov 24, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qw4990, XuHuaiyu, YangKeao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #48793
Problem Summary:
ScalarFunction.GetCtxis deprecated because we are going to remove inner context in function. We should remove some call ofScalarFunction.GetCtxin planner packageWhat is changed and how it works?
avoid to use
ScalarFunction.GetCtxin some planner codesCheck List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.