-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: e2e test for global kill #44905
Conversation
Signed-off-by: Ping Yu <[email protected]>
Signed-off-by: Ping Yu <[email protected]>
Signed-off-by: Ping Yu <[email protected]>
Signed-off-by: Ping Yu <[email protected]>
Signed-off-by: Ping Yu <[email protected]>
Signed-off-by: Ping Yu <[email protected]>
Hi @pingyu. Thanks for your PR. I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Signed-off-by: Ping Yu <[email protected]>
Signed-off-by: Ping Yu <[email protected]>
…test Signed-off-by: Ping Yu <[email protected]>
Signed-off-by: Ping Yu <[email protected]>
/retest |
/run-e2e-test |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #44905 +/- ##
================================================
+ Coverage 73.2290% 73.3959% +0.1669%
================================================
Files 1265 1268 +3
Lines 389829 392700 +2871
================================================
+ Hits 285468 288226 +2758
- Misses 86064 86162 +98
- Partials 18297 18312 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Ping Yu <[email protected]>
/retest |
Signed-off-by: Ping Yu <[email protected]>
Signed-off-by: Ping Yu <[email protected]>
Signed-off-by: Ping Yu <[email protected]>
@pingyu: GitHub didn't allow me to request PR reviews from the following users: xuyifangreeneyes. Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
PTAL, thanks~ |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: breezewish, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: ref #8854, close #45692
Problem Summary: Support CTRL-C or kill to kill a connection/query by implementing global connection IDs
What is changed and how it works?
Note: depends on #44460
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.