Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: e2e test for global kill #44905

Merged
merged 14 commits into from
Jul 31, 2023
Merged

Conversation

pingyu
Copy link
Contributor

@pingyu pingyu commented Jun 24, 2023

What problem does this PR solve?

Issue Number: ref #8854, close #45692

Problem Summary: Support CTRL-C or kill to kill a connection/query by implementing global connection IDs

What is changed and how it works?

  • Add e2e tests for 32bits global kill

Note: depends on #44460

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

tests: Add e2e tests for 32bits global kill.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels Jun 24, 2023
@pingyu pingyu marked this pull request as draft June 24, 2023 16:31
@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 24, 2023
@tiprow tiprow bot added the needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. label Jun 24, 2023
@tiprow
Copy link

tiprow bot commented Jun 24, 2023

Hi @pingyu. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels Jun 25, 2023
@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Jun 25, 2023
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 17, 2023
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 29, 2023
@pingyu
Copy link
Contributor Author

pingyu commented Jul 29, 2023

/retest

@pingyu
Copy link
Contributor Author

pingyu commented Jul 29, 2023

/run-e2e-test

@codecov
Copy link

codecov bot commented Jul 29, 2023

Codecov Report

Merging #44905 (4af9d57) into master (06ea55d) will increase coverage by 0.1669%.
Report is 11 commits behind head on master.
The diff coverage is 35.2941%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #44905        +/-   ##
================================================
+ Coverage   73.2290%   73.3959%   +0.1669%     
================================================
  Files          1265       1268         +3     
  Lines        389829     392700      +2871     
================================================
+ Hits         285468     288226      +2758     
- Misses        86064      86162        +98     
- Partials      18297      18312        +15     
Flag Coverage Δ
integration 78.1388% <ø> (?)
unit 73.3877% <35.2941%> (+0.1587%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.0417% <ø> (ø)
br 52.3672% <ø> (+0.2657%) ⬆️

@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 30, 2023
@pingyu
Copy link
Contributor Author

pingyu commented Jul 30, 2023

/retest
/run-e2e-test

Signed-off-by: Ping Yu <[email protected]>
@pingyu pingyu marked this pull request as ready for review July 30, 2023 09:21
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 30, 2023
pingyu added 2 commits July 30, 2023 18:02
Signed-off-by: Ping Yu <[email protected]>
Signed-off-by: Ping Yu <[email protected]>
@pingyu
Copy link
Contributor Author

pingyu commented Jul 30, 2023

/cc @breezewish @xuyifangreeneyes

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 30, 2023

@pingyu: GitHub didn't allow me to request PR reviews from the following users: xuyifangreeneyes.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @breezewish @xuyifangreeneyes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot requested a review from breezewish July 30, 2023 13:13
@pingyu
Copy link
Contributor Author

pingyu commented Jul 30, 2023

/cc @breezewish @xuyifangreeneyes

PTAL, thanks~

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 31, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: breezewish, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [breezewish,tangenta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 31, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 31, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-31 10:46:10.563915527 +0000 UTC m=+95854.506264104: ☑️ agreed by tangenta.
  • 2023-07-31 10:46:46.178516105 +0000 UTC m=+95890.120864636: ☑️ agreed by breezewish.

@ti-chi-bot ti-chi-bot bot merged commit eb49c39 into pingcap:master Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server ID is not released after Domain.Close
4 participants