Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: add more test cases for quick binding #44670

Merged
merged 2 commits into from
Jun 14, 2023
Merged

planner: add more test cases for quick binding #44670

merged 2 commits into from
Jun 14, 2023

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Jun 14, 2023

What problem does this PR solve?

Issue Number: ref #39199

Problem Summary: planner: add more test cases for quick binding

What is changed and how it works?

planner: add more test cases for quick binding

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 14, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 14, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 14, 2023
@ti-chi-bot ti-chi-bot bot removed the lgtm label Jun 14, 2023
@qw4990
Copy link
Contributor Author

qw4990 commented Jun 14, 2023

/test mysql-test

1 similar comment
@qw4990
Copy link
Contributor Author

qw4990 commented Jun 14, 2023

/test mysql-test

@qw4990
Copy link
Contributor Author

qw4990 commented Jun 14, 2023

/test check_dev_2

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 14, 2023

@qw4990: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build
  • /test canary-scan-security
  • /test check-dev
  • /test check-dev2
  • /test mysql-test
  • /test pingcap/tidb/canary_ghpr_unit_test
  • /test pull-integration-mysql-test
  • /test unit-test

Use /test all to run the following jobs that were automatically triggered:

  • pingcap/tidb/ghpr_build
  • pingcap/tidb/ghpr_check
  • pingcap/tidb/ghpr_check2
  • pingcap/tidb/ghpr_mysql_test
  • pingcap/tidb/ghpr_unit_test

In response to this:

/test check_dev_2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qw4990
Copy link
Contributor Author

qw4990 commented Jun 14, 2023

/test check-dev2

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 14, 2023
@qw4990
Copy link
Contributor Author

qw4990 commented Jun 14, 2023

/merge

@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 14, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, time-and-fate, xuyifangreeneyes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,time-and-fate,xuyifangreeneyes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 14, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 14, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-14 08:07:45.130476519 +0000 UTC m=+159461.545080585: ☑️ agreed by hawkingrei.
  • 2023-06-14 08:12:15.67303542 +0000 UTC m=+159732.087639494: ☑️ agreed by xuyifangreeneyes.
  • 2023-06-14 08:18:04.005489025 +0000 UTC m=+160080.420093114: ✖️🔁 reset by qw4990.
  • 2023-06-14 09:57:03.734774737 +0000 UTC m=+166020.149378816: ☑️ agreed by time-and-fate.
  • 2023-06-14 09:59:40.437852953 +0000 UTC m=+166176.852457032: ☑️ agreed by hawkingrei.

@qw4990
Copy link
Contributor Author

qw4990 commented Jun 14, 2023

/merge

@qw4990
Copy link
Contributor Author

qw4990 commented Jun 14, 2023

/test check-dev2

@ti-chi-bot ti-chi-bot bot merged commit 12c258e into pingcap:master Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@time-and-fate time-and-fate time-and-fate approved these changes

@xuyifangreeneyes xuyifangreeneyes xuyifangreeneyes approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qw4990 @hawkingrei @time-and-fate @xuyifangreeneyes