-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: Make DDL unaffected by killing TiDB instance #43871
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
PTAL @tiancaiamao |
KILL TiDB
/retest-required |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: a509ee1
|
KILL TiDB
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #43854
Problem Summary:
This issue support canceling DDL statements with KILL(related PR:*: fix a data race on TestConnExecutionTimeout #35923).
---The original PR that supported this didn't seem to say cancel DDL on "kill TiDB"
But after these PRs, when we do
kill TiDB
, this TiDB's DDLs may be canceled(In some cases it can't be cancelled).--- Cancel DDL is not fully supported in the case of "kill TiDB".
This issue need do "Pause user DDL when upgrading TiDB", but these DDLs may be canceled by
kill TiDB
. So we considerkill TiDB
can not cancel DDL.We'll deal with this in detail when we distinguish between asynchronous and synchronous DDLs.
What is changed and how it works?
If don't we kill TiDB can't cancel DDLs.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.