-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ttl: fix ttl job manager will panic if the status cache doesn't contain table (#41069) #43552
ttl: fix ttl job manager will panic if the status cache doesn't contain table (#41069) #43552
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
It also picks some parts of #41069, to resolve the conflict. |
4d1ad09
to
14a78ac
Compare
Signed-off-by: Yang Keao <[email protected]>
14a78ac
to
f0a55a1
Compare
/merge |
This pull request has been accepted and is ready to merge. Commit hash: f0a55a1
|
This cherry pick PR is for a release branch and has not yet been approved by release team. To merge this cherry pick, it must first be approved by the collaborators. AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #41069
Signed-off-by: YangKeao [email protected]
What problem does this PR solve?
Issue Number: close #41067, close #41068
Problem Summary:
What is changed and how it works?
err
withsqlErr
jobID
directly. We could start this job anyway, as the job manager actually did little things, and can be processed by other managers in the future. Also, the tasks has been spawned, we'd better to keep the task locally.I cannot reproduce the second situation in a natural way (except deleting the rows with concrete breakpoint). I'll add some tests about it after I understand how it occurs...
Could we try to restart the ttl job manager after it panics?