-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restore: split between tables #42972
Conversation
Signed-off-by: hillium <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 748fb23
|
/retest |
1 similar comment
/retest |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
This reverts commit 36c59c7.
What problem does this PR solve?
Issue Number: close #42924
Problem Summary:
When restoring tables, for optimization, we are not going to split between tables:
(Referencing #27240)
This works fine as long as we are restoring tables sequentially and restoring tables after we finish splitting. However, for now, in some scenarios:
t1
, i.e. the very left region oft2
. Which means... this region's epoch would change frequently, which probably blocks the import of t2.What is changed and how it works?
Check List
Tests
We detected this problem in an internal cluster, where v7.0.0 BR consistently fails, and with this PR we can restore to the cluster.
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.