Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statistics/handle: fix trigger auto analyze for partition table after adding index #41639

Merged
merged 1 commit into from
Feb 22, 2023
Merged

statistics/handle: fix trigger auto analyze for partition table after adding index #41639

merged 1 commit into from
Feb 22, 2023

Conversation

xuyifangreeneyes
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #41638

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Test #41638 manually.

  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 21, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • chrysan
  • qw4990

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 21, 2023
qw4990
qw4990 reviewed Feb 21, 2023
View reviewed changes
statistics/handle/update.go
@@ -1230,14 +1230,11 @@ func (h *Handle) autoAnalyzePartitionTableInDynamicMode(tblInfo *model.TableInfo
sqlBuilder.WriteString(suffix)
return sqlBuilder.String()
}
if len(partitionNames) < 1 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we remove this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the if branch exists, we would not go to the part of checking index stats(old Line1258-1289).

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 21, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. and removed status/LGT1 Indicates that a PR has LGTM 1. do-not-merge/needs-triage-completed labels Feb 21, 2023
@chrysan
Copy link
Contributor

chrysan commented Feb 22, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 24a830e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 22, 2023
@xuyifangreeneyes
Copy link
Contributor Author

/merge

@ti-chi-bot ti-chi-bot merged commit bf9f6c6 into pingcap:master Feb 22, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 22, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #41646.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Feb 22, 2023
@xuyifangreeneyes @ti-chi-bot
This is an automated cherry-pick of pingcap#41639
2c58a84 
Signed-off-by: ti-chi-bot <[email protected]>
@xuyifangreeneyes xuyifangreeneyes deleted the auto-analyze-partitions branch February 22, 2023 04:00
@chrysan chrysan mentioned this pull request Feb 22, 2023
Closed
ti-chi-bot bot pushed a commit that referenced this pull request Aug 17, 2023
@ti-chi-bot
statistics/handle: fix trigger auto analyze for partition table after…
e010e68 
… adding index (#41639) (#41646)

close #41638
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 approved these changes

@chrysan chrysan chrysan approved these changes

@Yisaer Yisaer Awaiting requested review from Yisaer

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

auto analyze of partition table is not triggered after adding index
4 participants
@xuyifangreeneyes @ti-chi-bot @chrysan @qw4990