Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: skip delay for async commit during merging temp index #38138

Closed
wants to merge 1 commit into from

Conversation

tangenta
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #35983

Problem Summary:

After @@tidb_ddl_enable_fast_reorg is enabled, there will be two reorganization steps: backfilll and merge. Because DDL has waited 2.5 seconds in the backfill step, it is guaranteed that none of the async commit transactions with old schema info(the newly adding index's schema state is none) are active. Thus, we don't have to wait another 2.5 seconds in the merge step.

What is changed and how it works?

Check List

Tests

  • Unit test

  • Integration test

  • Manual test (add detailed scripts or steps below)
    Before this PR, adding index takes 6 seconds even the table is empty:

    mysql> set @@global.tidb_ddl_enable_fast_reorg = 1;
    Query OK, 0 rows affected (0.03 sec)
    
    mysql> alter table t add index idx(a);
    Query OK, 0 rows affected (6.17 sec)
    

    After this PR, it takes about 3 seconds:

    alter table t add index idx(a);
    Query OK, 0 rows affected (3.11 sec)
    
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 23, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 23, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 24, 2022
@tangenta
Copy link
Contributor Author

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 26, 2022
@tangenta
Copy link
Contributor Author

We need to keep it for the correctness, closed.

@tangenta tangenta closed this Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants