-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
log-backup: let the advancer listen on the same range with the task #37783
Conversation
Signed-off-by: Yu Juncen <[email protected]>
Signed-off-by: Yu Juncen <[email protected]>
Signed-off-by: Yu Juncen <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: Yu Juncen <[email protected]>
Signed-off-by: Yu Juncen <[email protected]>
Signed-off-by: Yu Juncen <[email protected]>
Signed-off-by: Yu Juncen <[email protected]>
Signed-off-by: Yu Juncen <[email protected]>
Signed-off-by: Yu Juncen <[email protected]>
Signed-off-by: Yu Juncen <[email protected]>
/component br |
Signed-off-by: Yu Juncen <[email protected]>
Signed-off-by: Yu Juncen <[email protected]>
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 8264c9c
|
TiDB MergeCI notify🔴 Bad News! [2] CI still failing after this pr merged.
|
What problem does this PR solve?
Issue Number: close #37822
Problem Summary:
Perviously, the advancer would listen the full key space and wait all regions to get flushed then advancing the checkpoint.
In some condition (Maybe related to DR auto sync), PD may split at the key
m
, which leads to an always empty region ["", "m"). This region would never be observed by log-backup hence would never get flushed. Which leads to the checkpoint doesn't get advanced.What is changed and how it works?
This (huge) PR allows the advancer to listen the same range with the task.
Generally, it added a new field
taskRange
to theAdvancer
, and:CalculateGlobalCheckpoint
, it uses the task range as the initial range.CalculateGlobalCheckpointLight
, it would "clamp" the collected ranges within the task ranges. See theClampRanges
for details.ConsistencyCheck
, it would check the current ranges with the task range.Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.