Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log-backup: let the advancer listen on the same range with the task #37783

Merged
merged 21 commits into from
Sep 16, 2022

Conversation

YuJuncen
Copy link
Contributor

@YuJuncen YuJuncen commented Sep 13, 2022

What problem does this PR solve?

Issue Number: close #37822

Problem Summary:
Perviously, the advancer would listen the full key space and wait all regions to get flushed then advancing the checkpoint.
In some condition (Maybe related to DR auto sync), PD may split at the key m, which leads to an always empty region ["", "m"). This region would never be observed by log-backup hence would never get flushed. Which leads to the checkpoint doesn't get advanced.

What is changed and how it works?

This (huge) PR allows the advancer to listen the same range with the task.
Generally, it added a new field taskRange to the Advancer, and:

  • For CalculateGlobalCheckpoint, it uses the task range as the initial range.
  • For CalculateGlobalCheckpointLight, it would "clamp" the collected ranges within the task ranges. See the ClampRanges for details.
  • For ConsistencyCheck, it would check the current ranges with the task range.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fixed a bug that may cause log backup checkpoint TS stuck when some weird ranged regions exist. 

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 13, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • Leavrth

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 13, 2022
br/pkg/utils/key.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 14, 2022
@joccau
Copy link
Member

joccau commented Sep 14, 2022

/component br

@ti-chi-bot ti-chi-bot added the component/br This issue is related to BR of TiDB. label Sep 14, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 15, 2022
@YuJuncen
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8264c9c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 16, 2022
@ti-chi-bot ti-chi-bot merged commit ea58f1a into pingcap:master Sep 16, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Sep 16, 2022

TiDB MergeCI notify

🔴 Bad News! [2] CI still failing after this pr merged.
These failed integration tests don't seem to be introduced by the current PR.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/common-test 🔴 failed 1, success 10, total 11 53 min Existing failure
idc-jenkins-ci-tidb/integration-ddl-test 🔴 failed 1, success 5, total 6 23 min Existing failure
idc-jenkins-ci/integration-cdc-test 🟢 all 37 tests passed 24 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 8 min 39 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 3 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 4 min 26 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 11 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 9 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 53 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/br This issue is related to BR of TiDB. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PiTR task cannot get checkpoint ts
6 participants