Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/realtikvtest: add tests for adding index #37320

Merged
merged 7 commits into from
Aug 23, 2022
Merged

tests/realtikvtest: add tests for adding index #37320

merged 7 commits into from
Aug 23, 2022

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented Aug 23, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #35983

Problem Summary:

To improve the confidence that the code change about add-index optimization is correct, we add the integration tests first.

What is changed and how it works?

This PR adds the test for the ADD INDEX statements. It covers the following cases:

  • Different data types such as integers, decimals, time, char, blob and JSON.
  • Unique indexes, non-unique indexes and primary keys.
  • Range-partition table and non-partition table.
  • Insert, update and delete workloads during adding index.

Check List

Tests

  • Unit test
  • Integration test
    On my laptop, this test costs about 2 mins: 
    ok  	github.com/pingcap/tidb/tests/realtikvtest/addindextest	132.083s
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@tangenta tangenta requested a review from a team as a code owner August 23, 2022 13:40
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 23, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • hawkingrei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 23, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 23, 2022
@tangenta tangenta force-pushed the add-index-realtikv-test branch from 1659104 to d320da0 Compare August 23, 2022 13:48
@tangenta tangenta mentioned this pull request Aug 23, 2022
Closed
20 tasks
@sre-bot
Copy link
Contributor

sre-bot commented Aug 23, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/60e1a128fc6c639e291073a28984bc4bed8d7a73

@bb7133
Copy link
Member

bb7133 commented Aug 23, 2022

/run-mysql-test tidb-test=pr/1937

bb7133
bb7133 approved these changes Aug 23, 2022
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 23, 2022
@tangenta
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 10ce0f9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 23, 2022
@hawkingrei
Copy link
Member

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 23, 2022
@hawkingrei
Copy link
Member

wait for PingCAP-QE/ci#1294 merging

@hawkingrei
Copy link
Member

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 23, 2022
@hawkingrei
Copy link
Member

/run-mysql-test tidb-test=pr/1937

@hawkingrei
Copy link
Member

/merge

@hawkingrei
Copy link
Member

/run-mysql-test tidb-test=pr/1937

@ti-chi-bot ti-chi-bot merged commit 64c30c0 into pingcap:master Aug 23, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Aug 23, 2022

TiDB MergeCI notify

🔴 Bad News! [2] CI still failing after this pr merged.
These failed integration tests don't seem to be introduced by the current PR.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test 🔴 failed 4, success 13, total 17 15 min Existing failure
idc-jenkins-ci-tidb/common-test 🔴 failed 1, success 10, total 11 14 min Existing failure
idc-jenkins-ci/integration-cdc-test 🟢 all 36 tests passed 27 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 14 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 13 min Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 12 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 12 min Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 12 min Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 12 min Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@tangenta tangenta mentioned this pull request Sep 1, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@bb7133 bb7133 bb7133 approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tangenta @ti-chi-bot @sre-bot @bb7133 @hawkingrei