Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log-backup: added more metrics and hint; fixed a bug may cause inf loop #36228

Merged
merged 16 commits into from
Jul 18, 2022
Merged

log-backup: added more metrics and hint; fixed a bug may cause inf loop #36228

merged 16 commits into from
Jul 18, 2022

Conversation

YuJuncen
Copy link
Contributor

@YuJuncen YuJuncen commented Jul 15, 2022 •
edited
Loading

Signed-off-by: Yu Juncen [email protected]

What problem does this PR solve?

Issue Number: ref #29501

Problem Summary:
Before, we may get stuck after some region get merged because the poor exit reason of RegionIter.

What is changed and how it works?

Now, region iterator would exit if infScanFinished is true no matter the end key is inf.

Check List

Tests

  • Unit test (TBD)
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 15, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • Leavrth

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 15, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 15, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/c56a2441b9dd801cbba1680fbbeed1ca20ea4d27

@YuJuncen
added more tests
eb2664d 
Signed-off-by: Yu Juncen <[email protected]>
3pointer
3pointer reviewed Jul 15, 2022
View reviewed changes
br/pkg/streamhelper/advancer.go Outdated Show resolved Hide resolved
br/pkg/streamhelper/advancer.go Outdated Show resolved Hide resolved
YuJuncen added 2 commits July 15, 2022 19:17
@YuJuncen
make clippy happy
0ae162f 
Signed-off-by: Yu Juncen <[email protected]>
@YuJuncen
remove logs for debug usage
68e08f7 
Signed-off-by: Yu Juncen <[email protected]>
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 15, 2022
@3pointer
Copy link
Contributor

rest LGTM, I think we can give a meaningful log messages. because not only we will check the log. every one can see the log too. some log is not easy for other people to understand.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 18, 2022
3pointer
3pointer approved these changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@3pointer 3pointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 18, 2022
@3pointer
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f0acd5f

@ti-chi-bot ti-chi-bot added status/can-merge Indicates a PR has been approved by a committer. and removed do-not-merge/needs-linked-issue labels Jul 18, 2022
@3pointer
Copy link
Contributor

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 18, 2022
@YuJuncen
Copy link
Contributor Author

/run-check_dev
/run-mysql-test
/run-unit-test

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jul 18, 2022
@3pointer
Copy link
Contributor

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 18, 2022
@3pointer
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 55f9db9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 18, 2022
@YuJuncen
Copy link
Contributor Author

/run-check_dev

@YuJuncen
Copy link
Contributor Author

/run-all-tests

@3pointer
Copy link
Contributor

/run-check_dev_2

@ti-chi-bot ti-chi-bot merged commit 9859512 into pingcap:master Jul 18, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 18, 2022

TiDB MergeCI notify

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🟢 all 36 tests passed 26 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 11 tests passed 24 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 12 tests passed 13 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 7 min 29 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 7 min 0 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 6 min 32 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 30 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 12 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 2 min 49 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3pointer 3pointer 3pointer approved these changes

@Leavrth Leavrth Leavrth approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@YuJuncen @ti-chi-bot @sre-bot @3pointer @Leavrth