Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: expend interface of lightning for add index acceleration #36091

Merged
merged 7 commits into from
Aug 4, 2022
Merged

ddl: expend interface of lightning for add index acceleration #36091

merged 7 commits into from
Aug 4, 2022

Conversation

Benjamin2037
Copy link
Collaborator

@Benjamin2037 Benjamin2037 commented Jul 11, 2022 •
edited by tangenta
Loading

What problem does this PR solve?

Issue Number: ref #35983

Problem Summary:
This pr expand the currently interface for add index lightning solution.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 11, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • gozssky
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 11, 2022
@Benjamin2037
Copy link
Collaborator Author

/run ut

@Benjamin2037
Copy link
Collaborator Author

/run-unit-test

@Benjamin2037 Benjamin2037 force-pushed the add_index_lightning_dev_branch_expend branch from a9d64ba to 9b686dd Compare July 11, 2022 10:28
@sre-bot
Copy link
Contributor

sre-bot commented Jul 11, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/df941817dfe689e978972ee8e97a033f9db68dbc

@Benjamin2037
Copy link
Collaborator Author

/run-check_dev_2

4 similar comments
@Benjamin2037
Copy link
Collaborator Author

/run-check_dev_2

@Benjamin2037
Copy link
Collaborator Author

/run-check_dev_2

@Benjamin2037
Copy link
Collaborator Author

/run-check_dev_2

@Benjamin2037
Copy link
Collaborator Author

/run-check_dev_2

@sleepymole sleepymole mentioned this pull request Jul 15, 2022
Merged
4 tasks
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 16, 2022
@Benjamin2037 Benjamin2037 requested a review from sleepymole July 19, 2022 08:10
@3pointer
Copy link
Contributor

/run-integration-br-tests

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 29, 2022
@Benjamin2037 Benjamin2037 requested a review from 3pointer August 1, 2022 06:49
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 1, 2022
@Benjamin2037 Benjamin2037 requested a review from tangenta August 1, 2022 08:01
@Benjamin2037 Benjamin2037 force-pushed the add_index_lightning_dev_branch_expend branch from 89fe425 to 761c3db Compare August 1, 2022 08:10
@Benjamin2037
Copy link
Collaborator Author

/run-build

@Benjamin2037
Copy link
Collaborator Author

/run-mysql-test

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 2, 2022
@tangenta
Copy link
Contributor

tangenta commented Aug 2, 2022

/run-integration-br-tests

@Benjamin2037
Copy link
Collaborator Author

/run-build

@Benjamin2037
Copy link
Collaborator Author

/run-integration-br-test

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 4, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 4, 2022
@tangenta
Copy link
Contributor

tangenta commented Aug 4, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 39f510e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 4, 2022
@ti-chi-bot
Copy link
Member

@Benjamin2037: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit fff7483 into pingcap:master Aug 4, 2022
@Benjamin2037 Benjamin2037 deleted the add_index_lightning_dev_branch_expend branch August 5, 2022 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta approved these changes

@sleepymole sleepymole sleepymole approved these changes

@hawkingrei hawkingrei Awaiting requested review from hawkingrei

@wjhuang2016 wjhuang2016 Awaiting requested review from wjhuang2016

@kennytm kennytm Awaiting requested review from kennytm

@3pointer 3pointer Awaiting requested review from 3pointer

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Benjamin2037 @ti-chi-bot @sre-bot @3pointer @tangenta @sleepymole