Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infoschema, executor: Add variables_info table to see sysvar details #35995

Merged
merged 2 commits into from
Jul 7, 2022
Merged

infoschema, executor: Add variables_info table to see sysvar details #35995

merged 2 commits into from
Jul 7, 2022

Conversation

joycse06
Copy link
Contributor

@joycse06 joycse06 commented Jul 6, 2022

What problem does this PR solve?

Issue Number: close #21446

Problem Summary:
Currently there's no easy way to find out which system variables have been changed from their default value in a TiDB Cluster which can be handy for debugging. Also currently there's no easy way to see if a variable is instance scope.

What is changed and how it works?

What's changed:

information_schema.variables_info has been added. This is a view and doesn't make any changes to persistence. The data is read from variable.GetSysVars() method.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

* `information_schema.variables_info` has been added which can be used to quickly check which variables has been changed from their default value.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 6, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Defined2014
  • morgo

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 6, 2022
@ti-chi-bot
Copy link
Member

Welcome @joycse06!

It looks like this is your first PR to pingcap/tidb 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/tidb. 😃

@morgo
Copy link
Contributor

morgo commented Jul 6, 2022

/run-unit-test
/run-check_dev_2

@sre-bot
Copy link
Contributor

sre-bot commented Jul 6, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/7da845bb9ee1653f48b3314ce727485f7f1c821a

@morgo morgo self-requested a review July 7, 2022 00:41
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 7, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 7, 2022
@Defined2014
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c66b9ad

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 7, 2022
@ti-chi-bot ti-chi-bot merged commit adab58b into pingcap:master Jul 7, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 7, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/common-test 🟥 failed 1, success 11, total 12 13 min New failing
idc-jenkins-ci/integration-cdc-test 🟢 all 35 tests passed 28 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 11 tests passed 22 min Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 5 min 45 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 33 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 4 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 20 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 1 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 2 min 48 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@tangenta tangenta mentioned this pull request Jul 28, 2022
Merged
13 tasks
tangenta
tangenta reviewed Jul 28, 2022
View reviewed changes
infoschema/tables.go
@@ -1486,6 +1489,17 @@ var tablePlacementPoliciesCols = []columnInfo{
{name: "LEARNERS", tp: mysql.TypeLonglong, size: 64},
}

var tableVariablesInfoCols = []columnInfo{
{name: "VARIABLE_NAME", tp: mysql.TypeVarchar, size: 64, flag: mysql.NotNullFlag},
{name: "VARIABLES_SCOPE", tp: mysql.TypeVarchar, size: 64, flag: mysql.NotNullFlag},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VARIABLES_SCOPE -> VARIABLE_SCOPE

Is it a typo?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I agree it should be variable scope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta left review comments

@morgo morgo morgo approved these changes

@Defined2014 Defined2014 Defined2014 approved these changes

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add information_schema.variables_info view
6 participants
@joycse06 @ti-chi-bot @morgo @sre-bot @Defined2014 @tangenta